[libvirt] [PATCH 0/9] virClassNew rework

Michal Privoznik posted 9 patches 6 years ago
Failed in applying to current master (apply log)
Test syntax-check passed
There is a newer version of this series
cfg.mk                                  |   8 ++
src/access/viraccessmanager.c           |   6 +-
src/bhyve/bhyve_conf.c                  |   6 +-
src/conf/capabilities.c                 |  10 +--
src/conf/domain_capabilities.c          |  12 +--
src/conf/domain_conf.c                  |  22 ++----
src/conf/domain_event.c                 | 130 +++++++++++---------------------
src/conf/network_event.c                |  12 +--
src/conf/node_device_event.c            |  18 ++---
src/conf/object_event.c                 |  12 +--
src/conf/secret_event.c                 |  18 ++---
src/conf/storage_event.c                |  18 ++---
src/conf/virdomainobjlist.c             |   6 +-
src/conf/virinterfaceobj.c              |  12 +--
src/conf/virnetworkobj.c                |  12 +--
src/conf/virnodedeviceobj.c             |  14 ++--
src/conf/virsecretobj.c                 |  12 +--
src/conf/virstorageobj.c                |  24 ++----
src/datatypes.c                         |   8 +-
src/datatypes.h                         |  30 ++++----
src/interface/interface_backend_netcf.c |   6 +-
src/libvirt-admin.c                     |   8 +-
src/libvirt-domain-snapshot.c           |   2 +-
src/libvirt-domain.c                    |   2 +-
src/libvirt-host.c                      |   2 +-
src/libvirt-interface.c                 |   2 +-
src/libvirt-network.c                   |   2 +-
src/libvirt-nodedev.c                   |   8 +-
src/libvirt-nwfilter.c                  |   2 +-
src/libvirt-secret.c                    |   2 +-
src/libvirt-storage.c                   |   4 +-
src/libvirt-stream.c                    |   2 +-
src/libxl/libxl_conf.c                  |   6 +-
src/libxl/libxl_domain.c                |   6 +-
src/libxl/libxl_migration.c             |   6 +-
src/logging/log_handler.c               |   6 +-
src/lxc/lxc_conf.c                      |   6 +-
src/lxc/lxc_monitor.c                   |   6 +-
src/node_device/node_device_driver.c    |   4 +-
src/node_device/node_device_udev.c      |   6 +-
src/qemu/qemu_agent.c                   |   6 +-
src/qemu/qemu_capabilities.c            |   8 +-
src/qemu/qemu_conf.c                    |   6 +-
src/qemu/qemu_domain.c                  |  36 +++------
src/qemu/qemu_monitor.c                 |   6 +-
src/rpc/virkeepalive.c                  |   6 +-
src/rpc/virnetclient.c                  |   6 +-
src/rpc/virnetclientprogram.c           |   8 +-
src/rpc/virnetclientstream.c            |   6 +-
src/rpc/virnetdaemon.c                  |   6 +-
src/rpc/virnetlibsshsession.c           |   6 +-
src/rpc/virnetsaslcontext.c             |  18 +++--
src/rpc/virnetserver.c                  |   6 +-
src/rpc/virnetserverclient.c            |   6 +-
src/rpc/virnetserverprogram.c           |   8 +-
src/rpc/virnetserverservice.c           |   8 +-
src/rpc/virnetsocket.c                  |   6 +-
src/rpc/virnetsshsession.c              |   6 +-
src/rpc/virnettlscontext.c              |  12 +--
src/security/security_manager.c         |   6 +-
src/test/test_driver.c                  |   6 +-
src/util/virclosecallbacks.c            |   6 +-
src/util/virdnsmasq.c                   |   9 +--
src/util/virfdstream.c                  |  10 +--
src/util/virfilecache.c                 |   8 +-
src/util/virhash.c                      |   6 +-
src/util/virhostdev.c                   |   6 +-
src/util/viridentity.c                  |   6 +-
src/util/virmacmap.c                    |   8 +-
src/util/virmacmap.h                    |   2 +-
src/util/virmdev.c                      |   6 +-
src/util/virobject.c                    |  43 ++++++-----
src/util/virobject.h                    |   7 ++
src/util/virpci.c                       |   6 +-
src/util/virportallocator.c             |   6 +-
src/util/virresctrl.c                   |  12 +--
src/util/virscsi.c                      |   6 +-
src/util/virscsivhost.c                 |   6 +-
src/util/virusb.c                       |   6 +-
src/vbox/vbox_common.c                  |   6 +-
src/vz/vz_driver.c                      |   6 +-
tests/virfilecachetest.c                |   8 +-
82 files changed, 322 insertions(+), 517 deletions(-)
[libvirt] [PATCH 0/9] virClassNew rework
Posted by Michal Privoznik 6 years ago
This is inspired by commit of f574e2e5214fb9. Also, the more the code is
unified the easier it is to maintain.

Michal Privoznik (9):
  domain_event: s/MetadataCange/MetadataChange/g
  util: Make structs follow our naming convention
  datatypes: Rename @parent to @parentName in virNodeDevice
  src: Unify virObject member name
  src: Unify dispose function names
  Introduce virNetSASLContextDispose
  virobject: Introduce VIR_CLASS_NEW() macro
  virobject: Check if @parent is the first member in class
  cfg.mk: Introduce syntax-check rule to prefer VIR_CLASS_NEW

 cfg.mk                                  |   8 ++
 src/access/viraccessmanager.c           |   6 +-
 src/bhyve/bhyve_conf.c                  |   6 +-
 src/conf/capabilities.c                 |  10 +--
 src/conf/domain_capabilities.c          |  12 +--
 src/conf/domain_conf.c                  |  22 ++----
 src/conf/domain_event.c                 | 130 +++++++++++---------------------
 src/conf/network_event.c                |  12 +--
 src/conf/node_device_event.c            |  18 ++---
 src/conf/object_event.c                 |  12 +--
 src/conf/secret_event.c                 |  18 ++---
 src/conf/storage_event.c                |  18 ++---
 src/conf/virdomainobjlist.c             |   6 +-
 src/conf/virinterfaceobj.c              |  12 +--
 src/conf/virnetworkobj.c                |  12 +--
 src/conf/virnodedeviceobj.c             |  14 ++--
 src/conf/virsecretobj.c                 |  12 +--
 src/conf/virstorageobj.c                |  24 ++----
 src/datatypes.c                         |   8 +-
 src/datatypes.h                         |  30 ++++----
 src/interface/interface_backend_netcf.c |   6 +-
 src/libvirt-admin.c                     |   8 +-
 src/libvirt-domain-snapshot.c           |   2 +-
 src/libvirt-domain.c                    |   2 +-
 src/libvirt-host.c                      |   2 +-
 src/libvirt-interface.c                 |   2 +-
 src/libvirt-network.c                   |   2 +-
 src/libvirt-nodedev.c                   |   8 +-
 src/libvirt-nwfilter.c                  |   2 +-
 src/libvirt-secret.c                    |   2 +-
 src/libvirt-storage.c                   |   4 +-
 src/libvirt-stream.c                    |   2 +-
 src/libxl/libxl_conf.c                  |   6 +-
 src/libxl/libxl_domain.c                |   6 +-
 src/libxl/libxl_migration.c             |   6 +-
 src/logging/log_handler.c               |   6 +-
 src/lxc/lxc_conf.c                      |   6 +-
 src/lxc/lxc_monitor.c                   |   6 +-
 src/node_device/node_device_driver.c    |   4 +-
 src/node_device/node_device_udev.c      |   6 +-
 src/qemu/qemu_agent.c                   |   6 +-
 src/qemu/qemu_capabilities.c            |   8 +-
 src/qemu/qemu_conf.c                    |   6 +-
 src/qemu/qemu_domain.c                  |  36 +++------
 src/qemu/qemu_monitor.c                 |   6 +-
 src/rpc/virkeepalive.c                  |   6 +-
 src/rpc/virnetclient.c                  |   6 +-
 src/rpc/virnetclientprogram.c           |   8 +-
 src/rpc/virnetclientstream.c            |   6 +-
 src/rpc/virnetdaemon.c                  |   6 +-
 src/rpc/virnetlibsshsession.c           |   6 +-
 src/rpc/virnetsaslcontext.c             |  18 +++--
 src/rpc/virnetserver.c                  |   6 +-
 src/rpc/virnetserverclient.c            |   6 +-
 src/rpc/virnetserverprogram.c           |   8 +-
 src/rpc/virnetserverservice.c           |   8 +-
 src/rpc/virnetsocket.c                  |   6 +-
 src/rpc/virnetsshsession.c              |   6 +-
 src/rpc/virnettlscontext.c              |  12 +--
 src/security/security_manager.c         |   6 +-
 src/test/test_driver.c                  |   6 +-
 src/util/virclosecallbacks.c            |   6 +-
 src/util/virdnsmasq.c                   |   9 +--
 src/util/virfdstream.c                  |  10 +--
 src/util/virfilecache.c                 |   8 +-
 src/util/virhash.c                      |   6 +-
 src/util/virhostdev.c                   |   6 +-
 src/util/viridentity.c                  |   6 +-
 src/util/virmacmap.c                    |   8 +-
 src/util/virmacmap.h                    |   2 +-
 src/util/virmdev.c                      |   6 +-
 src/util/virobject.c                    |  43 ++++++-----
 src/util/virobject.h                    |   7 ++
 src/util/virpci.c                       |   6 +-
 src/util/virportallocator.c             |   6 +-
 src/util/virresctrl.c                   |  12 +--
 src/util/virscsi.c                      |   6 +-
 src/util/virscsivhost.c                 |   6 +-
 src/util/virusb.c                       |   6 +-
 src/vbox/vbox_common.c                  |   6 +-
 src/vz/vz_driver.c                      |   6 +-
 tests/virfilecachetest.c                |   8 +-
 82 files changed, 322 insertions(+), 517 deletions(-)

-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list