From nobody Thu May 2 14:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523017381569858.8050302834731; Fri, 6 Apr 2018 05:23:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C605985546; Fri, 6 Apr 2018 12:22:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F2162CFD5; Fri, 6 Apr 2018 12:22:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C2FDA180005A; Fri, 6 Apr 2018 12:22:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w36CMouk010792 for ; Fri, 6 Apr 2018 08:22:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0C9AD2024CA7; Fri, 6 Apr 2018 12:22:50 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7ED6D2024CA5; Fri, 6 Apr 2018 12:22:49 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 6 Apr 2018 14:22:46 +0200 Message-Id: <0f73ce9dbdbd23d24748e71263a3b4cf014adbf1.1523017341.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: jtomko@redhat.com Subject: [libvirt] [PATCH 1/2] storageVolLookupData: Drop conn struct member X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 06 Apr 2018 12:23:00 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since its introduction in 5d5c732d748d64 it has been never used. Signed-off-by: Michal Privoznik --- src/storage/storage_driver.c | 5 ++--- src/test/test_driver.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index d5e38af5aa..6ddead1b95 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1520,7 +1520,6 @@ storageVolLookupByName(virStoragePoolPtr pool, =20 =20 struct storageVolLookupData { - virConnectPtr conn; const char *key; char *cleanpath; const char *path; @@ -1547,7 +1546,7 @@ storageVolLookupByKey(virConnectPtr conn, virStoragePoolObjPtr obj; virStoragePoolDefPtr def; struct storageVolLookupData data =3D { - .conn =3D conn, .key =3D key, .voldef =3D NULL }; + .key =3D key, .voldef =3D NULL }; virStorageVolPtr vol =3D NULL; =20 if ((obj =3D virStoragePoolObjListSearch(driver->pools, @@ -1627,7 +1626,7 @@ storageVolLookupByPath(virConnectPtr conn, virStoragePoolObjPtr obj; virStoragePoolDefPtr def; struct storageVolLookupData data =3D { - .conn =3D conn, .path =3D path, .voldef =3D NULL }; + .path =3D path, .voldef =3D NULL }; virStorageVolPtr vol =3D NULL; =20 if (!(data.cleanpath =3D virFileSanitizePath(path))) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5e39ae574c..856869c9d3 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5026,7 +5026,6 @@ testStorageVolLookupByName(virStoragePoolPtr pool, =20 =20 struct storageVolLookupData { - virConnectPtr conn; const char *key; const char *path; virStorageVolDefPtr voldef; @@ -5053,7 +5052,7 @@ testStorageVolLookupByKey(virConnectPtr conn, virStoragePoolObjPtr obj; virStoragePoolDefPtr def; struct storageVolLookupData data =3D { - .conn =3D conn, .key =3D key, .voldef =3D NULL }; + .key =3D key, .voldef =3D NULL }; virStorageVolPtr vol =3D NULL; =20 testDriverLock(privconn); @@ -5097,7 +5096,7 @@ testStorageVolLookupByPath(virConnectPtr conn, virStoragePoolObjPtr obj; virStoragePoolDefPtr def; struct storageVolLookupData data =3D { - .conn =3D conn, .path =3D path, .voldef =3D NULL }; + .path =3D path, .voldef =3D NULL }; virStorageVolPtr vol =3D NULL; =20 testDriverLock(privconn); --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu May 2 14:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523017376959264.9434181009103; Fri, 6 Apr 2018 05:22:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39D004E8AB; Fri, 6 Apr 2018 12:22:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CACDE183C5; Fri, 6 Apr 2018 12:22:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A8E64CA9E; Fri, 6 Apr 2018 12:22:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w36CMoMK010802 for ; Fri, 6 Apr 2018 08:22:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id CEF5C2024CA7; Fri, 6 Apr 2018 12:22:50 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4ED9E2024CA5; Fri, 6 Apr 2018 12:22:50 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 6 Apr 2018 14:22:47 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: jtomko@redhat.com Subject: [libvirt] [PATCH 2/2] storageDriverAutostart: Drop unused @conn X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 06 Apr 2018 12:22:55 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This variable is not actually used in the function. Especially after 31869efe2a8. Signed-off-by: Michal Privoznik --- src/storage/storage_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 6ddead1b95..173b91b61b 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -218,13 +218,9 @@ storageDriverAutostartCallback(virStoragePoolObjPtr ob= j, static void storageDriverAutostart(void) { - virConnectPtr conn =3D NULL; - virStoragePoolObjListForEach(driver->pools, storageDriverAutostartCallback, NULL); - - virObjectUnref(conn); } =20 /** --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list