[libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0

Ján Tomko posted 4 patches 6 years ago
Failed in applying to current master (apply log)
Test syntax-check passed
tests/qemuxml2argvdata/watchdog.args               |    9 +-
tests/qemuxml2argvdata/x86-kvm-32-on-64.args       |    9 +-
tests/qemuxml2argvtest.c                           |  744 +++----
tests/qemuxml2xmltest.c                            |  119 +-
670 files changed, 4582 insertions(+), 14981 deletions(-)
delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.replies
delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml
delete mode 100644 tests/qemucapabilitiesdata/caps_1.3.1.x86_64.replies
delete mode 100644 tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml
delete mode 100644 tests/qemucapabilitiesdata/caps_1.4.2.x86_64.replies
delete mode 100644 tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml
delete mode 100644 tests/qemuhelpdata/qemu-0.12.1
delete mode 100644 tests/qemuhelpdata/qemu-0.12.1-device
delete mode 100644 tests/qemuhelpdata/qemu-1.0
delete mode 100644 tests/qemuhelpdata/qemu-1.0-device
delete mode 100644 tests/qemuhelpdata/qemu-1.1.0
delete mode 100644 tests/qemuhelpdata/qemu-1.1.0-device
delete mode 100644 tests/qemuhelpdata/qemu-1.2.0
delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3
delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3-device
delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0
delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0-device
delete mode 100644 tests/qemuhelpdata/qemu-kvm-1.2.0
delete mode 100644 tests/qemuhelptest.c
delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.args
delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.xml
[libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0
Posted by Ján Tomko 6 years ago
v2:
* Change the version from 1.3.0 to 1.5.0
* Mention this breaks RHEL 6 QEMU and list the versions
in relevant long-term releases

Some of the patches are very big, available in my repo:
https://repo.or.cz/libvirt/jtomko.git/shortlog/refs/heads/caps_cleanup_v2
git fetch git://repo.or.cz/libvirt/jtomko.git caps_cleanup_v2:

Ján Tomko (44):
  qemuxml2argvtest: Fix q35-virt-manager capabilities
  Delete bogus cpu-host-passthrough test
  Force QMP capability probing
  Require QEMU 1.5.0

  The following patches are nearly identical to v1:
  * rebased on the 1.3.1 and 1.4.2 caps deletion
  * luks-disks-source-qcow2.args is fixed

  Deprecate QEMU_CAPS_PCI_MULTIFUNCTION
  Deprecate QEMU_CAPS_NETDEV
  Clean up qemuDomainAttachNetDevice
  Remove unused qemuDomainNetVLAN
  Remove qemuDomainSupportsNetdev
  Deprecate QEMU_CAPS_MONITOR_JSON
  Deprecate QEMU_CAPS_NO_USER_CONFIG
  Deprecate QEMU_CAPS_MEM_PATH
  Deprecate QEMU_CAPS_DRIVE_SERIAL
  Deprecate QEMU_CAPS_SDL
  Deprecate QEMU_CAPS_RTC
  Deprecate QEMU_CAPS_RTC_TD_HACK
  Deprecate QEMU_CAPS_VHOST_NET
  Deprecate QEMU_CAPS_NODEFCONFIG
  Deprecate QEMU_CAPS_BOOT_MENU
  Deprecate QEMU_CAPS_FSDEV
  Deprecate QEMU_CAPS_NAME_PROCESS
  Deprecate QEMU_CAPS_SMBIOS_TYPE
  Deprecate QEMU_CAPS_VGA_NONE
  Deprecate QEMU_CAPS_DRIVE_AIO
  Deprecate QEMU_CAPS_CHARDEV_SPICEVMC
  Deprecate QEMU_CAPS_DEVICE_SPICEVMC
  Deprecate QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC
  Deprecate QEMU_CAPS_NO_SHUTDOWN
  Deprecate QEMU_CAPS_DRIVE_CACHE_UNSAFE
  Deprecate QEMU_CAPS_FSDEV_READONLY
  Deprecate QEMU_CAPS_DRIVE_COPY_ON_READ
  Deprecate QEMU_CAPS_FSDEV_WRITEOUT
  Deprecate QEMU_CAPS_DRIVE_IOTUNE
  Deprecate QEMU_CAPS_WAKEUP
  Deprecate QEMU_CAPS_NETDEV_BRIDGE
  Deprecate QEMU_CAPS_SECCOMP_SANDBOX
  Deprecate QEMU_CAPS_DTB
  Deprecate QEMU_CAPS_IPV6_MIGRATION
  Deprecate QEMU_CAPS_MACHINE_OPT
  Deprecate QEMU_CAPS_DUMP_GUEST_CORE
  Deprecate QEMU_CAPS_VNC_SHARE_POLICY
  Deprecate QEMU_CAPS_HOST_PCI_MULTIDOMAIN
  Deprecate QEMU_CAPS_DISPLAY
  Deprecate QEMU_CAPS_MACHINE_USB_OPT

 cfg.mk                                             |    2 +-
 src/qemu/qemu_capabilities.c                       |  936 +--------
 src/qemu/qemu_capabilities.h                       |   74 +-
 src/qemu/qemu_capspriv.h                           |   17 +-
 src/qemu/qemu_command.c                            |  690 ++----
 src/qemu/qemu_domain.c                             |   16 -
 src/qemu/qemu_domain.h                             |    6 -
 src/qemu/qemu_driver.c                             |   48 +-
 src/qemu/qemu_hotplug.c                            |  147 +-
 src/qemu/qemu_interface.c                          |    4 +-
 src/qemu/qemu_interface.h                          |    1 -
 src/qemu/qemu_migration.c                          |   10 +-
 src/qemu/qemu_process.c                            |   23 +-
 tests/Makefile.am                                  |    8 +-
 .../qemucapabilitiesdata/caps_1.2.2.x86_64.replies | 1886 -----------------
 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml   |  172 --
 .../qemucapabilitiesdata/caps_1.3.1.x86_64.replies | 2141 -------------------
 tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml   |  196 --
 .../qemucapabilitiesdata/caps_1.4.2.x86_64.replies | 2191 --------------------
 tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml   |  198 --
 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml |   35 -
 tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml  |   35 -
 tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml |   35 -
 tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  |   35 -
 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml  |   35 -
 tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml    |   35 -
 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml    |   35 -
 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml    |   35 -
 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |   35 -
 tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml    |   35 -
 tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml    |   35 -
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |   35 -
 tests/qemucapabilitiestest.c                       |    3 -
 tests/qemucapsprobe.c                              |    2 +-
 tests/qemuhelpdata/qemu-0.12.1                     |  198 --
 tests/qemuhelpdata/qemu-0.12.1-device              |   62 -
 tests/qemuhelpdata/qemu-1.0                        |  253 ---
 tests/qemuhelpdata/qemu-1.0-device                 |  148 --
 tests/qemuhelpdata/qemu-1.1.0                      |  269 ---
 tests/qemuhelpdata/qemu-1.1.0-device               |  170 --
 tests/qemuhelpdata/qemu-1.2.0                      |  272 ---
 tests/qemuhelpdata/qemu-kvm-0.12.3                 |  215 --
 tests/qemuhelpdata/qemu-kvm-0.12.3-device          |   63 -
 tests/qemuhelpdata/qemu-kvm-0.13.0                 |  242 ---
 tests/qemuhelpdata/qemu-kvm-0.13.0-device          |   90 -
 tests/qemuhelpdata/qemu-kvm-1.2.0                  |  277 ---
 tests/qemuhelptest.c                               |  437 ----
 .../aarch64-aavmf-virtio-mmio.args                 |   14 +-
 tests/qemuxml2argvdata/aarch64-acpi-uefi.args      |    9 +-
 [... lots of .args files ...]
 tests/qemuxml2argvdata/watchdog.args               |    9 +-
 tests/qemuxml2argvdata/x86-kvm-32-on-64.args       |    9 +-
 tests/qemuxml2argvtest.c                           |  744 +++----
 tests/qemuxml2xmltest.c                            |  119 +-
 670 files changed, 4582 insertions(+), 14981 deletions(-)
 delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.replies
 delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml
 delete mode 100644 tests/qemucapabilitiesdata/caps_1.3.1.x86_64.replies
 delete mode 100644 tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml
 delete mode 100644 tests/qemucapabilitiesdata/caps_1.4.2.x86_64.replies
 delete mode 100644 tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml
 delete mode 100644 tests/qemuhelpdata/qemu-0.12.1
 delete mode 100644 tests/qemuhelpdata/qemu-0.12.1-device
 delete mode 100644 tests/qemuhelpdata/qemu-1.0
 delete mode 100644 tests/qemuhelpdata/qemu-1.0-device
 delete mode 100644 tests/qemuhelpdata/qemu-1.1.0
 delete mode 100644 tests/qemuhelpdata/qemu-1.1.0-device
 delete mode 100644 tests/qemuhelpdata/qemu-1.2.0
 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3
 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3-device
 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0
 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0-device
 delete mode 100644 tests/qemuhelpdata/qemu-kvm-1.2.0
 delete mode 100644 tests/qemuhelptest.c
 delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.args
 delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.xml

-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0
Posted by Ján Tomko 6 years ago
On Thu, Apr 05, 2018 at 02:22:51PM +0200, Ján Tomko wrote:
>v2:
>* Change the version from 1.3.0 to 1.5.0
>* Mention this breaks RHEL 6 QEMU and list the versions
>in relevant long-term releases
>
>Some of the patches are very big, available in my repo:
>https://repo.or.cz/libvirt/jtomko.git/shortlog/refs/heads/caps_cleanup_v2
>git fetch git://repo.or.cz/libvirt/jtomko.git caps_cleanup_v2:
>

v3: rebased on top of master (with minor .args conflicts fixed)

http://repo.or.cz/libvirt/jtomko.git/shortlog/refs/heads/caps_cleanup_v3
git fetch git://repo.or.cz/libvirt/jtomko.git caps_cleanup_v3:

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0
Posted by Andrea Bolognani 6 years ago
On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote:
> v2:
> * Change the version from 1.3.0 to 1.5.0
> * Mention this breaks RHEL 6 QEMU and list the versions
> in relevant long-term releases
> 
> Some of the patches are very big, available in my repo:
> https://repo.or.cz/libvirt/jtomko.git/shortlog/refs/heads/caps_cleanup_v2
> git fetch git://repo.or.cz/libvirt/jtomko.git caps_cleanup_v2:

Can you please send snipped versions of the patches to the list,
eg. redact the test suite churn but leave the actual code changes
intact? At least for those patches where such changes are not
trivial and might thus warrant review feedback...

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list