From nobody Mon Apr 29 08:26:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 152216909692775.60992943499696; Tue, 27 Mar 2018 09:44:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79CF37F7AE; Tue, 27 Mar 2018 16:44:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E0F1620C6; Tue, 27 Mar 2018 16:44:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0F4BF181BA05; Tue, 27 Mar 2018 16:44:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2RGiive022719 for ; Tue, 27 Mar 2018 12:44:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4A540202698A; Tue, 27 Mar 2018 16:44:44 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id E62972026990 for ; Tue, 27 Mar 2018 16:44:43 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Tue, 27 Mar 2018 18:44:41 +0200 Message-Id: <01cfff7c3849dcd7937d330bfcec9373aa64029c.1522169052.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 1/2] Initialize struct using 0 instead of NULL X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 27 Mar 2018 16:44:56 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/connect.c | 4 ++-- src/domain.c | 4 ++-- src/gdbus.c | 4 ++-- src/main.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/connect.c b/src/connect.c index 56ead8d..c6b85ce 100644 --- a/src/connect.c +++ b/src/connect.c @@ -281,7 +281,7 @@ virtDBusDomainLookupByUUID(GVariant *inArgs, =20 static virtDBusGDBusPropertyTable virtDBusConnectPropertyTable[] =3D { { "Version", virtDBusConnectGetVersion, NULL }, - { NULL, NULL, NULL } + { 0 } }; =20 static virtDBusGDBusMethodTable virtDBusConnectMethodTable[] =3D { @@ -291,7 +291,7 @@ static virtDBusGDBusMethodTable virtDBusConnectMethodTa= ble[] =3D { { "DomainLookupByID", virtDBusDomainLookupByID }, { "DomainLookupByName", virtDBusDomainLookupByName }, { "DomainLookupByUUID", virtDBusDomainLookupByUUID }, - { NULL, NULL } + { 0 } }; =20 static GDBusInterfaceInfo *interfaceInfo =3D NULL; diff --git a/src/domain.c b/src/domain.c index 3c09351..1b9c685 100644 --- a/src/domain.c +++ b/src/domain.c @@ -459,7 +459,7 @@ static virtDBusGDBusPropertyTable virtDBusDomainPropert= yTable[] =3D { { "Persistent", virtDBusDomainGetPersistent, NULL }, { "State", virtDBusDomainGetState, NULL }, { "Autostart", virtDBusDomainGetAutostart, NULL }, - { NULL, NULL, NULL } + { 0 } }; =20 static virtDBusGDBusMethodTable virtDBusDomainMethodTable[] =3D { @@ -472,7 +472,7 @@ static virtDBusGDBusMethodTable virtDBusDomainMethodTab= le[] =3D { { "Reset", virtDBusDomainReset }, { "Create", virtDBusDomainCreate }, { "Undefine", virtDBusDomainUndefine }, - { NULL, NULL } + { 0 } }; =20 static gchar ** diff --git a/src/gdbus.c b/src/gdbus.c index 6abcc28..cb06813 100644 --- a/src/gdbus.c +++ b/src/gdbus.c @@ -294,7 +294,7 @@ static const GDBusInterfaceVTable virtDBusGDBusVtable = =3D { virtDBusGDBusHandleMethodCall, NULL, NULL, - { NULL } + { 0 } }; =20 /** @@ -378,7 +378,7 @@ static const GDBusSubtreeVTable virtDBusGDBusSubreeVtab= le =3D { virtDBusGDBusEnumerate, virtDBusGDBusIntrospect, virtDBusGDBusDispatch, - { NULL } + { 0 } }; =20 static void diff --git a/src/main.c b/src/main.c index 7afde4f..b3baf76 100644 --- a/src/main.c +++ b/src/main.c @@ -113,7 +113,7 @@ main(gint argc, gchar *argv[]) "Connect to the session bus", NULL }, { "threads", 't', 0, G_OPTION_ARG_INT, &maxThreads, "Configure maximal number of worker threads", "N" }, - { NULL } + { 0 } }; =20 context =3D g_option_context_new("Provide a D-Bus interface to a libvi= rtd."); --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 08:26:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1522169091996216.48244122709195; Tue, 27 Mar 2018 09:44:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88A697AE95; Tue, 27 Mar 2018 16:44:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48D8118B8D; Tue, 27 Mar 2018 16:44:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E4294CA9D; Tue, 27 Mar 2018 16:44:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2RGijv5022726 for ; Tue, 27 Mar 2018 12:44:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id DCC6E2026E03; Tue, 27 Mar 2018 16:44:44 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 842672026990 for ; Tue, 27 Mar 2018 16:44:44 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Tue, 27 Mar 2018 18:44:42 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 2/2] util: Introduce virtDBusUtilAutoLock X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 27 Mar 2018 16:44:51 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" clang 6.0.0 complains about unused variable if g_autoptr is used to automatically unlock mutex. Signed-off-by: Pavel Hrdina --- src/connect.c | 2 +- src/util.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/connect.c b/src/connect.c index c6b85ce..2350736 100644 --- a/src/connect.c +++ b/src/connect.c @@ -56,7 +56,7 @@ gboolean virtDBusConnectOpen(virtDBusConnect *connect, GError **error) { - g_autoptr(GMutexLocker) lock =3D g_mutex_locker_new(&connect->lock); + virtDBusUtilAutoLock lock =3D g_mutex_locker_new(&connect->lock); =20 if (connect->connection) { if (virConnectIsAlive(connect->connection)) diff --git a/src/util.h b/src/util.h index a34f863..4304bac 100644 --- a/src/util.h +++ b/src/util.h @@ -6,6 +6,8 @@ =20 #define VIRT_DBUS_ERROR virtDBusErrorQuark() =20 +#define virtDBusUtilAutoLock g_autoptr(GMutexLocker) G_GNUC_UNUSED + typedef enum { VIRT_DBUS_ERROR_LIBVIRT, VIRT_DBUS_N_ERRORS /*< skip >*/ --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list