From nobody Fri May 3 09:21:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1521118185267798.3650062616722; Thu, 15 Mar 2018 05:49:45 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1AAD97FEAD; Thu, 15 Mar 2018 12:49:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE5C1648CD; Thu, 15 Mar 2018 12:49:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A9342181B9FE; Thu, 15 Mar 2018 12:49:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2FCnXu0025275 for ; Thu, 15 Mar 2018 08:49:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id D8B072026E04; Thu, 15 Mar 2018 12:49:33 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 809772026980 for ; Thu, 15 Mar 2018 12:49:33 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 15 Mar 2018 13:49:29 +0100 Message-Id: <1b8388d5e34173351677420c3436870cbe3d865b.1521118155.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] src: Don't add virarptable.c to setuid library X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 15 Mar 2018 12:49:44 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The setuid-rpc-client.la is intended to be small and contain only bare minimum of source files. virarptable.c is not one of them. Signed-off-by: Michal Privoznik Reviewed-by: Chen Hanxiao Reviewed-by: Daniel P. Berrang=C3=A9 --- src/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 82c5d5cde8..8b1e4c8a4e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -672,7 +672,6 @@ noinst_LTLIBRARIES +=3D libvirt-setuid-rpc-client.la libvirt_setuid_rpc_client_la_SOURCES =3D \ util/viralloc.c \ util/virarch.c \ - util/virarptable.c \ util/viratomic.c \ util/viratomic.h \ util/virbitmap.c \ --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Fri May 3 09:21:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1521118181751537.2875279708995; Thu, 15 Mar 2018 05:49:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 602DFC05250A; Thu, 15 Mar 2018 12:49:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3E218600C0; Thu, 15 Mar 2018 12:49:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 074AB4CA9C; Thu, 15 Mar 2018 12:49:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2FCnYDW025283 for ; Thu, 15 Mar 2018 08:49:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 76BE12026E04; Thu, 15 Mar 2018 12:49:34 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E6BE2026E0E for ; Thu, 15 Mar 2018 12:49:33 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 15 Mar 2018 13:49:30 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] virarptable: Include rtnetlink.h only on Linux X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 15 Mar 2018 12:49:40 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" And at the same time, do that from .c rather than .h file. Signed-off-by: Michal Privoznik Reviewed-by: Chen Hanxiao Reviewed-by: Daniel P. Berrang=C3=A9 --- src/util/virarptable.c | 3 +++ src/util/virarptable.h | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virarptable.c b/src/util/virarptable.c index 2730ef91af..8d9ab5fdc8 100644 --- a/src/util/virarptable.c +++ b/src/util/virarptable.c @@ -26,6 +26,9 @@ #include #include #include +#ifdef __linux__ +# include +#endif =20 #include "viralloc.h" #include "virarptable.h" diff --git a/src/util/virarptable.h b/src/util/virarptable.h index 404d8eb867..6829198128 100644 --- a/src/util/virarptable.h +++ b/src/util/virarptable.h @@ -25,7 +25,6 @@ # define __VIR_ARPTABLE_H__ =20 # include "internal.h" -# include =20 typedef struct _virArpTableEntry virArpTableEntry; typedef virArpTableEntry *virArpTableEntryPtr; --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list