[libvirt] [PATCH 00/10] conf: Make disk source parsing cleaner and reusable

Peter Krempa posted 10 patches 6 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1520951803.git.pkrempa@redhat.com
Test syntax-check passed
src/conf/domain_conf.c   | 402 ++++++++++++++++++++++++++++-------------------
src/conf/domain_conf.h   |  13 ++
src/libvirt_private.syms |   2 +
3 files changed, 254 insertions(+), 163 deletions(-)
[libvirt] [PATCH 00/10] conf: Make disk source parsing cleaner and reusable
Posted by Peter Krempa 6 years, 1 month ago
Fixup and cleanup the disk source parsing code and make it usable in
other parts of the code by exporting it.

Peter Krempa (10):
  conf: Remove unnecessary condition from
    virDomainDiskSourceFormatInternal
  conf: Refactor seclabel formatting in
    virDomainDiskSourceFormatInternal
  conf: Remove virDomainDiskSourceDefFormatSeclabel
  conf: Refactor formatting of startupPolicy in
    virDomainDiskSourceFormatInternal
  conf: disk: Separate virStorageSource formatting
  conf: Validate disk source configuration also for the backing store
  conf: Separate seclabel validation from parsing
  conf: Parse and validate disk source seclabels together with the
    source
  conf: Extract parsing of storage source related data
  conf: Add and export wrapper for parsing storage source XML

 src/conf/domain_conf.c   | 402 ++++++++++++++++++++++++++++-------------------
 src/conf/domain_conf.h   |  13 ++
 src/libvirt_private.syms |   2 +
 3 files changed, 254 insertions(+), 163 deletions(-)

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/10] conf: Make disk source parsing cleaner and reusable
Posted by Michal Privoznik 6 years, 1 month ago
On 03/13/2018 03:37 PM, Peter Krempa wrote:
> Fixup and cleanup the disk source parsing code and make it usable in
> other parts of the code by exporting it.
> 
> Peter Krempa (10):
>   conf: Remove unnecessary condition from
>     virDomainDiskSourceFormatInternal
>   conf: Refactor seclabel formatting in
>     virDomainDiskSourceFormatInternal
>   conf: Remove virDomainDiskSourceDefFormatSeclabel
>   conf: Refactor formatting of startupPolicy in
>     virDomainDiskSourceFormatInternal
>   conf: disk: Separate virStorageSource formatting
>   conf: Validate disk source configuration also for the backing store
>   conf: Separate seclabel validation from parsing
>   conf: Parse and validate disk source seclabels together with the
>     source
>   conf: Extract parsing of storage source related data
>   conf: Add and export wrapper for parsing storage source XML
> 
>  src/conf/domain_conf.c   | 402 ++++++++++++++++++++++++++++-------------------
>  src/conf/domain_conf.h   |  13 ++
>  src/libvirt_private.syms |   2 +
>  3 files changed, 254 insertions(+), 163 deletions(-)
> 

ACK to patches 1-9.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list