Drop old Policy-Kit support

[libvirt] [PATCH 0/3] Drop old Policy-Kit support

Posted by Ján Tomko 6 years, 1 month ago

The build WITH_POLKIT0 and -Wunused-label was broken for almost two
years.

Ján Tomko (3):
  Remove Policy-Kit support
  Merge WITH_POLKIT1 and WITH_POLKIT
  Do not check for pkcheck

 .gitignore                                         |   1 -
 m4/virt-polkit.m4                                  |  80 +++------------
 src/access/Makefile.inc.am                         |   6 +-
 src/access/viraccessmanager.c                      |   4 +-
 src/libvirt.c                                      |  27 -----
 src/remote/Makefile.inc.am                         |  24 +----
 src/remote/{libvirtd.policy.in => libvirtd.policy} |   6 +-
 src/remote/remote_driver.c                         |  63 ------------
 src/util/Makefile.inc.am                           |   2 -
 src/util/virpolkit.c                               | 113 +--------------------
 tests/Makefile.am                                  |   4 +-
 11 files changed, 28 insertions(+), 302 deletions(-)
 rename src/remote/{libvirtd.policy.in => libvirtd.policy} (92%)

-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Drop old Policy-Kit support

Posted by Daniel P. Berrangé 6 years, 1 month ago

On Wed, Mar 07, 2018 at 10:29:29AM +0100, Ján Tomko wrote:
> The build WITH_POLKIT0 and -Wunused-label was broken for almost two
> years.

Last time we discussed this, SUSE folks said they still had polkit0 on
an actively supported distro. I'd like confirmation they don't still
need it before removing, so copying Jim.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Drop old Policy-Kit support

Posted by Peter Krempa 6 years, 1 month ago

On Wed, Mar 07, 2018 at 10:15:35 +0000, Daniel Berrange wrote:
> On Wed, Mar 07, 2018 at 10:29:29AM +0100, Ján Tomko wrote:
> > The build WITH_POLKIT0 and -Wunused-label was broken for almost two
> > years.
> 
> Last time we discussed this, SUSE folks said they still had polkit0 on
> an actively supported distro. I'd like confirmation they don't still
> need it before removing, so copying Jim.

Probably not very actively used though since nobody complained that it
was broken for so long.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Drop old Policy-Kit support

Posted by Daniel P. Berrangé 6 years, 1 month ago

On Wed, Mar 07, 2018 at 12:09:15PM +0100, Peter Krempa wrote:
> On Wed, Mar 07, 2018 at 10:15:35 +0000, Daniel Berrange wrote:
> > On Wed, Mar 07, 2018 at 10:29:29AM +0100, Ján Tomko wrote:
> > > The build WITH_POLKIT0 and -Wunused-label was broken for almost two
> > > years.
> > 
> > Last time we discussed this, SUSE folks said they still had polkit0 on
> > an actively supported distro. I'd like confirmation they don't still
> > need it before removing, so copying Jim.
> 
> Probably not very actively used though since nobody complained that it
> was broken for so long.

Well downstreams don't run with -Werror usually, so fact that -Wunused-label
generated a warning doesn't mean it was broken for downstreams.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Drop old Policy-Kit support

Posted by Jim Fehlig 6 years, 1 month ago

On 03/07/2018 03:15 AM, Daniel P. Berrangé wrote:
> On Wed, Mar 07, 2018 at 10:29:29AM +0100, Ján Tomko wrote:
>> The build WITH_POLKIT0 and -Wunused-label was broken for almost two
>> years.
> 
> Last time we discussed this, SUSE folks said they still had polkit0 on
> an actively supported distro. I'd like confirmation they don't still
> need it before removing, so copying Jim.

SLES 11 contains polkit0 and is actively supported, but I don't see any reason 
for that old distro to hamstring upstream. The SLES11 target was removed from 
automated builds of libvirt.git quite a while back.

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list