Fix overly complex parsing of storage encryption/authentication

[libvirt] [PATCH 0/6] Fix overly complex parsing of storage encryption/authentication

Peter Krempa posted 6 patches 6 years, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1520346349.git.pkrempa@redhat.com

Test syntax-check passed

src/conf/domain_conf.c          | 69 +++++++++--------------------------------
src/conf/storage_conf.c         |  5 ++-
src/util/virstorageencryption.c | 67 +++++++++++++--------------------------
src/util/virstorageencryption.h |  4 +--
src/util/virstoragefile.c       | 53 ++++++++++---------------------
src/util/virstoragefile.h       |  3 +-
6 files changed, 59 insertions(+), 142 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/6] Fix overly complex parsing of storage encryption/authentication

Posted by Peter Krempa 6 years, 1 month ago

Peter Krempa (6):
  util: storage: Simplify error handling in virStorageAuthDefParseXML
  util: storage: Sanitize parsing of disk auth XMLs
  conf: Replace virDomainDiskSourceAuthParse by an XPath query
  util: storageencryption: Refactor cleanup section in
    virStorageEncryptionParseXML
  util: storage: Sanitize parsing of disk encryption XMLs
  conf: Replace virDomainDiskSourceEncryptionParse by an XPath query

 src/conf/domain_conf.c          | 69 +++++++++--------------------------------
 src/conf/storage_conf.c         |  5 ++-
 src/util/virstorageencryption.c | 67 +++++++++++++--------------------------
 src/util/virstorageencryption.h |  4 +--
 src/util/virstoragefile.c       | 53 ++++++++++---------------------
 src/util/virstoragefile.h       |  3 +-
 6 files changed, 59 insertions(+), 142 deletions(-)

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/6] Fix overly complex parsing of storage encryption/authentication

Posted by John Ferlan 6 years, 1 month ago


On 03/06/2018 09:27 AM, Peter Krempa wrote:
> Peter Krempa (6):
>   util: storage: Simplify error handling in virStorageAuthDefParseXML
>   util: storage: Sanitize parsing of disk auth XMLs
>   conf: Replace virDomainDiskSourceAuthParse by an XPath query
>   util: storageencryption: Refactor cleanup section in
>     virStorageEncryptionParseXML
>   util: storage: Sanitize parsing of disk encryption XMLs
>   conf: Replace virDomainDiskSourceEncryptionParse by an XPath query
> 
>  src/conf/domain_conf.c          | 69 +++++++++--------------------------------
>  src/conf/storage_conf.c         |  5 ++-
>  src/util/virstorageencryption.c | 67 +++++++++++++--------------------------
>  src/util/virstorageencryption.h |  4 +--
>  src/util/virstoragefile.c       | 53 ++++++++++---------------------
>  src/util/virstoragefile.h       |  3 +-
>  6 files changed, 59 insertions(+), 142 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

(series)

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list