Fix trouble with <backingStore> in virsh detach-disk

[libvirt] [PATCH 0/3] Fix trouble with <backingStore> in virsh detach-disk

Peter Krempa posted 3 patches 6 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1518618392.git.pkrempa@redhat.com

src/util/virstoragefile.c |  8 ++++++++
tests/virstoragetest.c    | 15 +++------------
tools/virsh-domain.c      | 44 +++++++++++++++++++++++++++++++++-----------
tools/virsh.pod           |  4 ++++
4 files changed, 48 insertions(+), 23 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] Fix trouble with <backingStore> in virsh detach-disk

Posted by Peter Krempa 6 years, 2 months ago

We've created malformed <auth> element for RBD images in backing store
of a disk which failed parsing and broke detaching disks via virsh.

Fix it by not parsing auth data at all from the disk backing images and
remove the <backingStore> element when constructing the XML for disk
detach.

Peter Krempa (3):
  virsh: detach-disk: Add --print-xml switch
  util: storage: Remove detected authentication data for backing chains
  virsh: Remove <backingStore> sub-element in virshFindDisk

 src/util/virstoragefile.c |  8 ++++++++
 tests/virstoragetest.c    | 15 +++------------
 tools/virsh-domain.c      | 44 +++++++++++++++++++++++++++++++++-----------
 tools/virsh.pod           |  4 ++++
 4 files changed, 48 insertions(+), 23 deletions(-)

-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Fix trouble with <backingStore> in virsh detach-disk

Posted by Ján Tomko 6 years, 2 months ago

On Wed, Feb 14, 2018 at 03:57:23PM +0100, Peter Krempa wrote:
>We've created malformed <auth> element for RBD images in backing store
>of a disk which failed parsing and broke detaching disks via virsh.
>
>Fix it by not parsing auth data at all from the disk backing images and
>remove the <backingStore> element when constructing the XML for disk
>detach.
>
>Peter Krempa (3):
>  virsh: detach-disk: Add --print-xml switch
>  util: storage: Remove detected authentication data for backing chains
>  virsh: Remove <backingStore> sub-element in virshFindDisk
>
> src/util/virstoragefile.c |  8 ++++++++
> tests/virstoragetest.c    | 15 +++------------
> tools/virsh-domain.c      | 44 +++++++++++++++++++++++++++++++++-----------
> tools/virsh.pod           |  4 ++++
> 4 files changed, 48 insertions(+), 23 deletions(-)
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list