[libvirt] [PATCH 0/2] vsh: Print help for the aliased cmd rather than the alias itself

Erik Skultety posted 2 patches 6 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1516893631.git.eskultet@redhat.com
tools/vsh.c | 45 +++++++++++++++++----------------------------
tools/vsh.h |  4 ++--
2 files changed, 19 insertions(+), 30 deletions(-)
[libvirt] [PATCH 0/2] vsh: Print help for the aliased cmd rather than the alias itself
Posted by Erik Skultety 6 years, 2 months ago
The alias doesn't have any definition rather than a reference for the aliased
command. Therefore when printing help, we have to print help for the aliased
command, otherwise our faith is going to be met with SIGSEGV.

Erik Skultety (2):
  vsh: Drop redundant definition searches from vshCmd{def,Grp}Help
  vsh: Cmd aliases lookups should return results for the aliased command

 tools/vsh.c | 45 +++++++++++++++++----------------------------
 tools/vsh.h |  4 ++--
 2 files changed, 19 insertions(+), 30 deletions(-)

--
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] vsh: Print help for the aliased cmd rather than the alias itself
Posted by Michal Privoznik 6 years, 2 months ago
On 01/25/2018 04:22 PM, Erik Skultety wrote:
> The alias doesn't have any definition rather than a reference for the aliased
> command. Therefore when printing help, we have to print help for the aliased
> command, otherwise our faith is going to be met with SIGSEGV.
> 
> Erik Skultety (2):
>   vsh: Drop redundant definition searches from vshCmd{def,Grp}Help
>   vsh: Cmd aliases lookups should return results for the aliased command
> 
>  tools/vsh.c | 45 +++++++++++++++++----------------------------
>  tools/vsh.h |  4 ++--
>  2 files changed, 19 insertions(+), 30 deletions(-)
> 

ACK series

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] vsh: Print help for the aliased cmd rather than the alias itself
Posted by Erik Skultety 6 years, 2 months ago
On Thu, Jan 25, 2018 at 04:49:38PM +0100, Michal Privoznik wrote:
> On 01/25/2018 04:22 PM, Erik Skultety wrote:
> > The alias doesn't have any definition rather than a reference for the aliased
> > command. Therefore when printing help, we have to print help for the aliased
> > command, otherwise our faith is going to be met with SIGSEGV.
> >
> > Erik Skultety (2):
> >   vsh: Drop redundant definition searches from vshCmd{def,Grp}Help
> >   vsh: Cmd aliases lookups should return results for the aliased command
> >
> >  tools/vsh.c | 45 +++++++++++++++++----------------------------
> >  tools/vsh.h |  4 ++--
> >  2 files changed, 19 insertions(+), 30 deletions(-)
> >
>
> ACK series

Pushed, thanks.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list