The patches are trimmed out a lot to fit the size limit of our list. Anyway, the interesting bits are kept and also you can find the patches at my github: https://github.com/zippy2/libvirt/commits/qemuxml2argvdata If this approach is ACKed, I can continue because some other files suffer the same problem (e.g. qemuxml2xmloutdata). Michal Privoznik (2): tests: Drop qemuxml2argv- prefix for qemuxml2argv-*.xml test cases tests: Drop qemuxml2argv- prefix for qemuxml2argv test cases tests/qemuxml2argvtest.c | 4 ++-- tests/qemuxml2xmltest.c | 2 +- <very long list of renames/> 1481 files changed, 57 insertions(+), 57 deletions(-) -- 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Sat, 2017-12-02 at 08:11 +0100, Michal Privoznik wrote: > The patches are trimmed out a lot to fit the size limit of our list. Anyway, > the interesting bits are kept and also you can find the patches at my github: > > https://github.com/zippy2/libvirt/commits/qemuxml2argvdata > > If this approach is ACKed, I can continue because some other files suffer the > same problem (e.g. qemuxml2xmloutdata). > > Michal Privoznik (2): > tests: Drop qemuxml2argv- prefix for qemuxml2argv-*.xml test cases > tests: Drop qemuxml2argv- prefix for qemuxml2argv test cases > > tests/qemuxml2argvtest.c | 4 ++-- > tests/qemuxml2xmltest.c | 2 +- > <very long list of renames/> > 1481 files changed, 57 insertions(+), 57 deletions(-) Yes please! I suggest you wait a few days before pushing so that other people have a chance to chime in, but as far as I'm concerned Reviewed-by: Andrea Bolognani <abologna@redhat.com> for the whole series, and looking forward to more of this :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 12/04/2017 06:04 PM, Andrea Bolognani wrote: > On Sat, 2017-12-02 at 08:11 +0100, Michal Privoznik wrote: >> The patches are trimmed out a lot to fit the size limit of our list. Anyway, >> the interesting bits are kept and also you can find the patches at my github: >> >> https://github.com/zippy2/libvirt/commits/qemuxml2argvdata >> >> If this approach is ACKed, I can continue because some other files suffer the >> same problem (e.g. qemuxml2xmloutdata). >> >> Michal Privoznik (2): >> tests: Drop qemuxml2argv- prefix for qemuxml2argv-*.xml test cases >> tests: Drop qemuxml2argv- prefix for qemuxml2argv test cases >> >> tests/qemuxml2argvtest.c | 4 ++-- >> tests/qemuxml2xmltest.c | 2 +- >> <very long list of renames/> >> 1481 files changed, 57 insertions(+), 57 deletions(-) > > Yes please! > > I suggest you wait a few days before pushing so that other people > have a chance to chime in, but as far as I'm concerned > > Reviewed-by: Andrea Bolognani <abologna@redhat.com> > > for the whole series, and looking forward to more of this :) > Cool. Looks like we have a wide agreement on this. What's even more interesting is that the resulting .tar.xz is rougly ~5KiB smaller with this change. Frankly, I hoped that xz compresses the file names too. Whatever, I've pushed these. Thanks! Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Sat, Dec 02, 2017 at 08:11:48AM +0100, Michal Privoznik wrote: > The patches are trimmed out a lot to fit the size limit of our list. Anyway, > the interesting bits are kept and also you can find the patches at my github: > > https://github.com/zippy2/libvirt/commits/qemuxml2argvdata > > If this approach is ACKed, I can continue because some other files suffer the > same problem (e.g. qemuxml2xmloutdata). IIRC, this naming convention is my fault originally, but I can't think of a good reason why I did this. So ACK to trimming the redundant prefixes. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 12/02/2017 02:11 AM, Michal Privoznik wrote: > The patches are trimmed out a lot to fit the size limit of our list. Anyway, > the interesting bits are kept and also you can find the patches at my github: > > https://github.com/zippy2/libvirt/commits/qemuxml2argvdata > > If this approach is ACKed, I can continue because some other files suffer the > same problem (e.g. qemuxml2xmloutdata). > > Michal Privoznik (2): > tests: Drop qemuxml2argv- prefix for qemuxml2argv-*.xml test cases > tests: Drop qemuxml2argv- prefix for qemuxml2argv test cases > > tests/qemuxml2argvtest.c | 4 ++-- > tests/qemuxml2xmltest.c | 2 +- > <very long list of renames/> > 1481 files changed, 57 insertions(+), 57 deletions(-) > Seems reasonable from my viewpoint as well... Could be disruptive to any patches currently on list that have (or haven't) been reviewed. Not that I haven't caused those types of issues as well ;-) John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.