From nobody Tue Apr 30 06:59:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1512119409456873.1512622921457; Fri, 1 Dec 2017 01:10:09 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E00D561479; Fri, 1 Dec 2017 09:10:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB7596031E; Fri, 1 Dec 2017 09:10:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 840431800BDF; Fri, 1 Dec 2017 09:10:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vB199uZq008867 for ; Fri, 1 Dec 2017 04:09:56 -0500 Received: by smtp.corp.redhat.com (Postfix) id 82EC05D6A3; Fri, 1 Dec 2017 09:09:56 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 083945D6A2 for ; Fri, 1 Dec 2017 09:09:55 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 1 Dec 2017 10:09:44 +0100 Message-Id: <7d7c01b4580f471e1376e30d4092dcf45cfe0ccc.1512119320.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/3] virDomainDiskSourceNetworkParse: Don't leak @tlsCfg or @haveTLS X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 01 Dec 2017 09:10:08 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" =3D=3D861=3D=3D 3 bytes in 1 blocks are definitely lost in loss record 3 of= 168 =3D=3D861=3D=3D at 0x4C2AEDF: malloc (vg_replace_malloc.c:299) =3D=3D861=3D=3D by 0x8C7FBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4) =3D=3D861=3D=3D by 0x5DCCDC2: virXMLPropString (virxml.c:510) =3D=3D861=3D=3D by 0x5DF1232: virDomainDiskSourceNetworkParse (domain_co= nf.c:8445) =3D=3D861=3D=3D by 0x5DF1728: virDomainDiskSourceParse (domain_conf.c:85= 76) =3D=3D861=3D=3D by 0x5DF41A5: virDomainDiskDefParseXML (domain_conf.c:92= 38) =3D=3D861=3D=3D by 0x5E1119F: virDomainDefParseXML (domain_conf.c:19233) =3D=3D861=3D=3D by 0x5E146EE: virDomainDefParseNode (domain_conf.c:20083) =3D=3D861=3D=3D by 0x5E14540: virDomainDefParse (domain_conf.c:20027) =3D=3D861=3D=3D by 0x5E145E6: virDomainDefParseFile (domain_conf.c:20053) =3D=3D861=3D=3D by 0x4053CC: testCompareXMLToArgv (qemuxml2argvtest.c:45= 5) =3D=3D861=3D=3D by 0x41F135: virTestRun (testutils.c:180) Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 81cdf2cca..0fb1c4ad4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8500,6 +8500,8 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node, ret =3D 0; =20 cleanup: + VIR_FREE(tlsCfg); + VIR_FREE(haveTLS); VIR_FREE(protocol); return ret; } --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Tue Apr 30 06:59:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1512119400301158.22407343153668; Fri, 1 Dec 2017 01:10:00 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DADA66E770; Fri, 1 Dec 2017 09:09:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B3D3E5D960; Fri, 1 Dec 2017 09:09:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EDEA01800BC7; Fri, 1 Dec 2017 09:09:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vB199vbd008876 for ; Fri, 1 Dec 2017 04:09:57 -0500 Received: by smtp.corp.redhat.com (Postfix) id 56A855D6A3; Fri, 1 Dec 2017 09:09:57 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id D14F45D6A2 for ; Fri, 1 Dec 2017 09:09:56 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 1 Dec 2017 10:09:45 +0100 Message-Id: <0fd85b98aee9094bf61a2db86b795421119a41b5.1512119320.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] virDomainDiskBackingStoreParse: Don't leak @idx X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 01 Dec 2017 09:09:59 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" =3D=3D1277=3D=3D 8 bytes in 4 blocks are definitely lost in loss record 39 = of 131 =3D=3D1277=3D=3D at 0x4C2AEDF: malloc (vg_replace_malloc.c:299) =3D=3D1277=3D=3D by 0x68BBBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.= 4) =3D=3D1277=3D=3D by 0x53B1DC2: virXMLPropString (virxml.c:510) =3D=3D1277=3D=3D by 0x53D696A: virDomainDiskBackingStoreParse (domain_co= nf.c:8639) =3D=3D1277=3D=3D by 0x53DA684: virDomainDiskDefParseXML (domain_conf.c:9= 590) =3D=3D1277=3D=3D by 0x53F619F: virDomainDefParseXML (domain_conf.c:19233) =3D=3D1277=3D=3D by 0x53F96EE: virDomainDefParseNode (domain_conf.c:2008= 3) =3D=3D1277=3D=3D by 0x53F9540: virDomainDefParse (domain_conf.c:20027) =3D=3D1277=3D=3D by 0x53F95E6: virDomainDefParseFile (domain_conf.c:2005= 3) =3D=3D1277=3D=3D by 0x44D1D4: testCompareDomXML2XMLFiles (testutils.c:12= 65) =3D=3D1277=3D=3D by 0x42FC7C: testXML2XMLActive (qemuxml2xmltest.c:71) =3D=3D1277=3D=3D by 0x44AD20: virTestRun (testutils.c:180) Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0fb1c4ad4..66e21c4bd 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8682,6 +8682,7 @@ virDomainDiskBackingStoreParse(xmlXPathContextPtr ctx= t, virStorageSourceFree(backingStore); VIR_FREE(type); VIR_FREE(format); + VIR_FREE(idx); ctxt->node =3D save_ctxt; return ret; } --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Tue Apr 30 06:59:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1512119401688339.74972227262526; Fri, 1 Dec 2017 01:10:01 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C710C058EAF; Fri, 1 Dec 2017 09:10:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 046775C881; Fri, 1 Dec 2017 09:10:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C2A1F4A467; Fri, 1 Dec 2017 09:09:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vB199wUU008892 for ; Fri, 1 Dec 2017 04:09:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id A3C465D6AE; Fri, 1 Dec 2017 09:09:58 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id A57555D6A2 for ; Fri, 1 Dec 2017 09:09:57 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 1 Dec 2017 10:09:46 +0100 Message-Id: <3eb840904a088a89d05821d975ed4624962431f3.1512119320.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/3] qemuStateInitialize: Don't leak @memoryBackingPath X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 01 Dec 2017 09:10:00 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" =3D=3D899=3D=3D 39 bytes in 1 blocks are definitely lost in loss record 732= of 1,003 =3D=3D899=3D=3D at 0x4C2AEDF: malloc (vg_replace_malloc.c:299) =3D=3D899=3D=3D by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so) =3D=3D899=3D=3D by 0x55498D2: virVasprintfInternal (virstring.c:708) =3D=3D899=3D=3D by 0x55499E7: virAsprintfInternal (virstring.c:729) =3D=3D899=3D=3D by 0x2BECFFF0: qemuGetMemoryBackingBasePath (qemu_conf.c= :1757) =3D=3D899=3D=3D by 0x2BF23225: qemuStateInitialize (qemu_driver.c:893) =3D=3D899=3D=3D by 0x563073D: virStateInitialize (libvirt.c:770) =3D=3D899=3D=3D by 0x124CC4: daemonRunStateInit (libvirtd.c:834) =3D=3D899=3D=3D by 0x55521CD: virThreadHelper (virthread.c:206) =3D=3D899=3D=3D by 0x88D9686: start_thread (in /lib64/libpthread-2.25.so) =3D=3D899=3D=3D by 0x8BEAEFE: clone (in /lib64/libc-2.25.so) Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0ec5efbc2..5eae7d24a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -904,6 +904,7 @@ qemuStateInitialize(bool privileged, virFileUpdatePerm(memoryBackingPath, 0, S_IXGRP | S_IXOTH) < 0) goto error; + VIR_FREE(memoryBackingPath); =20 if (!(qemu_driver->closeCallbacks =3D virCloseCallbacksNew())) goto error; --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list