qemu: command: -drive formatting cleanups (blockdev-add saga)

[libvirt] [PATCH 0/9] qemu: command: -drive formatting cleanups (blockdev-add saga)

Posted by Peter Krempa 6 years, 5 months ago

Kill some ugly code.

Peter Krempa (9):
  util: Fix condition check in virDiskNameToIndex
  qemu: command: Remove dead code when formatting -drive
  qemu: command: Move disk index validation closer to usage
  qemu: command: Directly report bus type in qemuBuildDriveStrValidate
  qemu: command: Refactor qemuBuildDriveStrValidate to make qemuCaps
    optional
  qemu: command: Merge checks from qemuBuildDriveStrValidate to
    qemuCheckDiskConfig
  qemu: command: Refactor blkiotune checks to tolerate NULL qemuCaps
  qemu: command: Move blkiotune checks to qemuCheckDiskConfig
  qemu: command: Move disk serial validation to checker function

 src/qemu/qemu_command.c | 485 +++++++++++++++++++++++-------------------------
 src/qemu/qemu_command.h |   3 +-
 src/qemu/qemu_driver.c  |   2 +-
 src/util/virutil.c      |   2 +-
 4 files changed, 236 insertions(+), 256 deletions(-)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/9] qemu: command: -drive formatting cleanups (blockdev-add saga)

Posted by Ján Tomko 6 years, 5 months ago

On Fri, Nov 03, 2017 at 01:03:28PM +0100, Peter Krempa wrote:
>Kill some ugly code.
>
>Peter Krempa (9):
>  util: Fix condition check in virDiskNameToIndex
>  qemu: command: Remove dead code when formatting -drive
>  qemu: command: Move disk index validation closer to usage
>  qemu: command: Directly report bus type in qemuBuildDriveStrValidate
>  qemu: command: Refactor qemuBuildDriveStrValidate to make qemuCaps
>    optional
>  qemu: command: Merge checks from qemuBuildDriveStrValidate to
>    qemuCheckDiskConfig
>  qemu: command: Refactor blkiotune checks to tolerate NULL qemuCaps
>  qemu: command: Move blkiotune checks to qemuCheckDiskConfig
>  qemu: command: Move disk serial validation to checker function
>
> src/qemu/qemu_command.c | 485 +++++++++++++++++++++++-------------------------
> src/qemu/qemu_command.h |   3 +-
> src/qemu/qemu_driver.c  |   2 +-
> src/util/virutil.c      |   2 +-
> 4 files changed, 236 insertions(+), 256 deletions(-)
>

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list