qemu: Fix QoS for vhostuser

[libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

Posted by Michal Privoznik 6 years, 5 months ago

Setting QoS on the fly does work for vhostuser. However, it doesn't when
starting a domain. So when looking into this, I realized that we should be more
explicit about types of interface that do support QoS.

Michal Privoznik (2):
  qemuDomainSetInterfaceParameters: Explicitly reject unsupported net
    types
  virNetDevSupportBandwidth: Enable QoS for vhostuser

 src/conf/netdev_bandwidth_conf.h |  2 +-
 src/qemu/qemu_driver.c           | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

Posted by Michal Privoznik 6 years, 5 months ago

On 10/25/2017 12:48 PM, Michal Privoznik wrote:
> Setting QoS on the fly does work for vhostuser. However, it doesn't when
> starting a domain. So when looking into this, I realized that we should be more
> explicit about types of interface that do support QoS.
> 
> Michal Privoznik (2):
>   qemuDomainSetInterfaceParameters: Explicitly reject unsupported net
>     types
>   virNetDevSupportBandwidth: Enable QoS for vhostuser
> 
>  src/conf/netdev_bandwidth_conf.h |  2 +-
>  src/qemu/qemu_driver.c           | 21 +++++++++++++++++++++
>  2 files changed, 22 insertions(+), 1 deletion(-)
> 

Ping? I'd be nice to have this bug fix in the release.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

Posted by Martin Kletzander 6 years, 5 months ago

On Wed, Oct 25, 2017 at 12:48:08PM +0200, Michal Privoznik wrote:
>Setting QoS on the fly does work for vhostuser. However, it doesn't when
>starting a domain. So when looking into this, I realized that we should be more
>explicit about types of interface that do support QoS.
>

ACK & SFF

>Michal Privoznik (2):
>  qemuDomainSetInterfaceParameters: Explicitly reject unsupported net
>    types
>  virNetDevSupportBandwidth: Enable QoS for vhostuser
>
> src/conf/netdev_bandwidth_conf.h |  2 +-
> src/qemu/qemu_driver.c           | 21 +++++++++++++++++++++
> 2 files changed, 22 insertions(+), 1 deletion(-)
>
>-- 
>2.13.6
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

Posted by Michal Privoznik 6 years, 5 months ago

On 10/30/2017 11:44 AM, Martin Kletzander wrote:
> On Wed, Oct 25, 2017 at 12:48:08PM +0200, Michal Privoznik wrote:
>> Setting QoS on the fly does work for vhostuser. However, it doesn't when
>> starting a domain. So when looking into this, I realized that we
>> should be more
>> explicit about types of interface that do support QoS.
>>
> 
> ACK & SFF

Thanks, pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list