On 10/19/2017 11:34 AM, Peter Krempa wrote:
> These patches are part of John's original series located here:
>
> https://www.redhat.com/archives/libvir-list/2017-October/msg00228.html
>
> The patches are reordered and fixed to make more sense.
>
> Patch 1/5 is originally 5/16, without any modification. Patches 2/5 and
> 3/5 are split from patch 2/16 from original series.
>
> Patches 3/16 and 4/16 were dropped. Allocating the private data via
> xmlopt does not make sense since the storage-driver originating
> virStorageSources would not have them allocated anyways. We will
> allocate them when necessary in the qemu driver.
>
> The copy function was dropped, since the private data should not really
> be copied. It can be added later if necessary.
>
> The rest of the series will be posted later. I'm interrested in parsing
> of auth/encryption for backing chain members (1/16, 7/16) and the JSON
> generator from 15/16. I'll extract those parts in my upcoming
> blockdev-add saga postings and post the rest later.
>
> John Ferlan (5):
> qemu: Add missing encinfo cleanup
> util: storage: Introduce privateData for _virStorageSource
> qemu: Introduce privateData object for virStorageSource
> qemu: Relocate qemuDomainSecretInfoPtr to
> qemuDomainStorageSourcePrivate
> qemu: Move encinfo from private disk to private disk src
>
> src/qemu/qemu_command.c | 12 +++++-----
> src/qemu/qemu_domain.c | 60 ++++++++++++++++++++++++++++++++++++++---------
> src/qemu/qemu_domain.h | 26 +++++++++++++-------
> src/qemu/qemu_hotplug.c | 11 +++++----
> src/util/virstoragefile.c | 1 +
> src/util/virstoragefile.h | 3 +++
> 6 files changed, 82 insertions(+), 31 deletions(-)
>
I'm fine with the refactor - whatever works best. Feels strange to ACK
or R-B my own code, but if that's what you need, then consider it provided.
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list