From nobody Sun Apr 28 14:14:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1503301704251491.8188561933041; Mon, 21 Aug 2017 00:48:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DD602027A; Mon, 21 Aug 2017 07:48:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BC5E6C50A; Mon, 21 Aug 2017 07:48:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7956B1806107; Mon, 21 Aug 2017 07:48:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v7L7m4u1020874 for ; Mon, 21 Aug 2017 03:48:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7D68E7E2EA; Mon, 21 Aug 2017 07:48:04 +0000 (UTC) Received: from caroline.localdomain (unknown [10.43.2.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50B5B77D4A for ; Mon, 21 Aug 2017 07:48:02 +0000 (UTC) Received: from caroline.brq.redhat.com (caroline.brq.redhat.com [127.0.0.1]) by caroline.localdomain (Postfix) with ESMTP id CBD2512036C for ; Mon, 21 Aug 2017 09:48:00 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5DD602027A Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Martin Kletzander To: libvir-list@redhat.com Date: Mon, 21 Aug 2017 09:47:39 +0200 Message-Id: <4bfd9dd6ced625153c0fe5d2333cdb1c7be68a75.1503301615.git.mkletzan@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] util: Umark virBufferCheckErrorInternal as ATTRIBUTE_RETURN_CHECK X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 21 Aug 2017 07:48:22 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The function is useful even without using the return value. And if needed, the return value can be obtained by other calls as well. The potential for clean-up can be seen in the following patch. Signed-off-by: Martin Kletzander Reviewed-by: John Ferlan (series) --- src/util/virbuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h index f34217968b83..248c135b6077 100644 --- a/src/util/virbuffer.h +++ b/src/util/virbuffer.h @@ -58,7 +58,7 @@ int virBufferCheckErrorInternal(const virBuffer *buf, const char *filename, const char *funcname, size_t linenr) - ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1); + ATTRIBUTE_NONNULL(1); /** * virBufferCheckError * --=20 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun Apr 28 14:14:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1503301704312573.585473785464; Mon, 21 Aug 2017 00:48:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F524C047B84; Mon, 21 Aug 2017 07:48:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D22E6C513; Mon, 21 Aug 2017 07:48:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8005D3FAD1; Mon, 21 Aug 2017 07:48:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v7L7m4h4020888 for ; Mon, 21 Aug 2017 03:48:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id A2E5B6F45D; Mon, 21 Aug 2017 07:48:04 +0000 (UTC) Received: from caroline.localdomain (unknown [10.43.2.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 763F46F43F for ; Mon, 21 Aug 2017 07:48:02 +0000 (UTC) Received: from caroline.brq.redhat.com (caroline.brq.redhat.com [127.0.0.1]) by caroline.localdomain (Postfix) with ESMTP id D6CF712036E for ; Mon, 21 Aug 2017 09:48:00 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5F524C047B84 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Martin Kletzander To: libvir-list@redhat.com Date: Mon, 21 Aug 2017 09:47:40 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/4] util: Use virBufferCheckError to its full potential. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 21 Aug 2017 07:48:22 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We can now check for the error and not care about the return value as it will be properly handled in virBufferContentAndReset() anyway. Signed-off-by: Martin Kletzander Reviewed-by: John Ferlan (series) --- src/util/virbitmap.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index a5077fe7c8bf..57a8fbf82c78 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -332,11 +332,7 @@ char *virBitmapString(virBitmapPtr bitmap) bitmap->map[sz]); } =20 - if (virBufferError(&buf)) { - virBufferFreeAndReset(&buf); - return NULL; - } - + virBufferCheckError(&buf); return virBufferContentAndReset(&buf); } =20 --=20 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun Apr 28 14:14:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1503301691306663.6913338634031; Mon, 21 Aug 2017 00:48:11 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AFA87E427; Mon, 21 Aug 2017 07:48:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC664779F4; Mon, 21 Aug 2017 07:48:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7B91D1803B21; Mon, 21 Aug 2017 07:48:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v7L7m4fm020873 for ; Mon, 21 Aug 2017 03:48:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7E4A577BE6; Mon, 21 Aug 2017 07:48:04 +0000 (UTC) Received: from caroline.localdomain (unknown [10.43.2.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CC9D77BE5 for ; Mon, 21 Aug 2017 07:48:02 +0000 (UTC) Received: from caroline.brq.redhat.com (caroline.brq.redhat.com [127.0.0.1]) by caroline.localdomain (Postfix) with ESMTP id E19D4120503 for ; Mon, 21 Aug 2017 09:48:00 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6AFA87E427 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Martin Kletzander To: libvir-list@redhat.com Date: Mon, 21 Aug 2017 09:47:41 +0200 Message-Id: <87131e5f235c2c7cb19255a24c8ab92425d4bc7d.1503301615.git.mkletzan@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] conf: Clean up and report error in virDomainCapsFormat X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 21 Aug 2017 07:48:09 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Martin Kletzander Reviewed-by: John Ferlan (series) --- src/conf/domain_capabilities.c | 68 +++++++++++++++++---------------------= ---- 1 file changed, 28 insertions(+), 40 deletions(-) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index 7a81c10fd10f..35f8128e70dd 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -516,62 +516,50 @@ virDomainCapsFeatureGICFormat(virBufferPtr buf, } =20 =20 -static int -virDomainCapsFormatInternal(virBufferPtr buf, - virDomainCapsPtr const caps) +char * +virDomainCapsFormat(virDomainCapsPtr const caps) { + virBuffer buf =3D VIR_BUFFER_INITIALIZER; const char *virttype_str =3D virDomainVirtTypeToString(caps->virttype); const char *arch_str =3D virArchToString(caps->arch); =20 - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); =20 - virBufferEscapeString(buf, "%s\n", caps->path); - virBufferAsprintf(buf, "%s\n", virttype_str); + virBufferEscapeString(&buf, "%s\n", caps->path); + virBufferAsprintf(&buf, "%s\n", virttype_str); if (caps->machine) - virBufferAsprintf(buf, "%s\n", caps->machine); - virBufferAsprintf(buf, "%s\n", arch_str); + virBufferAsprintf(&buf, "%s\n", caps->machine); + virBufferAsprintf(&buf, "%s\n", arch_str); =20 if (caps->maxvcpus) - virBufferAsprintf(buf, "\n", caps->maxvcpus); + virBufferAsprintf(&buf, "\n", caps->maxvcpus); =20 - virDomainCapsOSFormat(buf, &caps->os); - virDomainCapsCPUFormat(buf, &caps->cpu); + virDomainCapsOSFormat(&buf, &caps->os); + virDomainCapsCPUFormat(&buf, &caps->cpu); =20 - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); =20 - virDomainCapsDeviceDiskFormat(buf, &caps->disk); - virDomainCapsDeviceGraphicsFormat(buf, &caps->graphics); - virDomainCapsDeviceVideoFormat(buf, &caps->video); - virDomainCapsDeviceHostdevFormat(buf, &caps->hostdev); + virDomainCapsDeviceDiskFormat(&buf, &caps->disk); + virDomainCapsDeviceGraphicsFormat(&buf, &caps->graphics); + virDomainCapsDeviceVideoFormat(&buf, &caps->video); + virDomainCapsDeviceHostdevFormat(&buf, &caps->hostdev); =20 - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); =20 - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); =20 - virDomainCapsFeatureGICFormat(buf, &caps->gic); + virDomainCapsFeatureGICFormat(&buf, &caps->gic); =20 - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); =20 - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); - return 0; -} - - -char * -virDomainCapsFormat(virDomainCapsPtr const caps) -{ - virBuffer buf =3D VIR_BUFFER_INITIALIZER; - - if (virDomainCapsFormatInternal(&buf, caps) < 0) { - virBufferFreeAndReset(&buf); - return NULL; - } + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); =20 + virBufferCheckError(&buf); return virBufferContentAndReset(&buf); } --=20 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sun Apr 28 14:14:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1503301691041583.1340710269297; Mon, 21 Aug 2017 00:48:11 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2705F356F0; Mon, 21 Aug 2017 07:48:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D06585F922; Mon, 21 Aug 2017 07:48:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 77E083FACE; Mon, 21 Aug 2017 07:48:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v7L7m4tP020876 for ; Mon, 21 Aug 2017 03:48:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 82CDA5E1D1; Mon, 21 Aug 2017 07:48:04 +0000 (UTC) Received: from caroline.localdomain (unknown [10.43.2.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5704D66824 for ; Mon, 21 Aug 2017 07:48:02 +0000 (UTC) Received: from caroline.brq.redhat.com (caroline.brq.redhat.com [127.0.0.1]) by caroline.localdomain (Postfix) with ESMTP id ECABD120508 for ; Mon, 21 Aug 2017 09:48:00 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2705F356F0 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Martin Kletzander To: libvir-list@redhat.com Date: Mon, 21 Aug 2017 09:47:42 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] conf: Clean up and report error in virDomainGenerateMachineName X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 21 Aug 2017 07:48:09 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Martin Kletzander Reviewed-by: John Ferlan (series) --- src/conf/domain_conf.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3bef5bed3b4a..fffdeb353581 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -27151,25 +27151,23 @@ virDomainGenerateMachineName(const char *driverna= me, const char *name, bool privileged) { - char *machinename =3D NULL; char *username =3D NULL; virBuffer buf =3D VIR_BUFFER_INITIALIZER; =20 if (privileged) { virBufferAsprintf(&buf, "%s-", drivername); } else { - if (!(username =3D virGetUserName(geteuid()))) - goto cleanup; - + if (!(username =3D virGetUserName(geteuid()))) { + virBufferFreeAndReset(&buf); + return NULL; + } virBufferAsprintf(&buf, "%s-%s-", username, drivername); + VIR_FREE(username); } =20 virBufferAsprintf(&buf, "%d-", id); virDomainMachineNameAppendValid(&buf, name); =20 - machinename =3D virBufferContentAndReset(&buf); - cleanup: - VIR_FREE(username); - - return machinename; + virBufferCheckError(&buf); + return virBufferContentAndReset(&buf); } --=20 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list