[v3] Fix error reporting in streams

[libvirt] [PATCH v3 0/6] Fix error reporting in streams

Michal Privoznik posted 6 patches 6 years, 10 months ago

Diff against v2 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1496650920.git.mprivozn@redhat.com

There is a newer version of this series

daemon/stream.c                  | 18 ++++++---
include/libvirt/libvirt-stream.h | 17 +++++++-
src/libvirt-stream.c             | 83 +++++++++++++++++++++++++++++++---------
src/util/virfdstream.c           | 22 ++++++++---
src/util/virfile.c               |  5 ++-
5 files changed, 113 insertions(+), 32 deletions(-)

Expand all Fold all

[libvirt] [PATCH v3 0/6] Fix error reporting in streams

Posted by Michal Privoznik 6 years, 10 months ago

diff to v3:

-In the last patch, instead of reporting errors from callbacks, report system
 error based on errno set by the callbacks.

Michal Privoznik (6):
  virfdstream: Check for thread error more frequently
  fdstream: Report error from the I/O thread
  virStream*All: Call virStreamAbort() more frequently
  virStream*All: Preserve reported error
  virFileInData: preserve errno in cleanup path
  virStream*All: Report error if a callback fails

 daemon/stream.c                  | 18 ++++++---
 include/libvirt/libvirt-stream.h | 17 +++++++-
 src/libvirt-stream.c             | 83 +++++++++++++++++++++++++++++++---------
 src/util/virfdstream.c           | 22 ++++++++---
 src/util/virfile.c               |  5 ++-
 5 files changed, 113 insertions(+), 32 deletions(-)

-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/6] Fix error reporting in streams

Posted by Michal Privoznik 6 years, 10 months ago

On 06/05/2017 10:22 AM, Michal Privoznik wrote:
> diff to v3:
> 
> -In the last patch, instead of reporting errors from callbacks, report system
>  error based on errno set by the callbacks.
> 
> Michal Privoznik (6):
>   virfdstream: Check for thread error more frequently
>   fdstream: Report error from the I/O thread
>   virStream*All: Call virStreamAbort() more frequently
>   virStream*All: Preserve reported error
>   virFileInData: preserve errno in cleanup path
>   virStream*All: Report error if a callback fails
> 
>  daemon/stream.c                  | 18 ++++++---
>  include/libvirt/libvirt-stream.h | 17 +++++++-
>  src/libvirt-stream.c             | 83 +++++++++++++++++++++++++++++++---------
>  src/util/virfdstream.c           | 22 ++++++++---
>  src/util/virfile.c               |  5 ++-
>  5 files changed, 113 insertions(+), 32 deletions(-)
> 


Ping? I'd like to backport these and couple of other stream fixes that
I've pushed earlier onto a stable branch since current release has
broken streams.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list