[v1] Implement sparse streams

[libvirt] [libvirt-perl][PATCH 0/7] Implement sparse streams

Posted by Michal Privoznik 6 years, 11 months ago

*** BLURB HERE ***

Michal Privoznik (7):
  Fix send_all() callback helper
  Introduce flags to Stream::recv()
  Introduce Stream::recvHole() and Stream::sendHole()
  Introduce Stream::sparse_recv_all()
  Introduce Stream::sparse_send_all()
  Register VOL_DOWNLOAD_SPARSE_STREAM & VOL_UPLOAD_SPARSE_STREAM
    constants
  examples: Introduce vol-sparse.pl

 Changes                    |   9 ++
 Virt.xs                    | 241 ++++++++++++++++++++++++++++++++++++++++++++-
 examples/vol-sparse.pl     | 142 ++++++++++++++++++++++++++
 lib/Sys/Virt/StorageVol.pm |  30 +++++-
 lib/Sys/Virt/Stream.pm     |  70 ++++++++++++-
 t/030-api-coverage.t       |   3 +
 6 files changed, 483 insertions(+), 12 deletions(-)
 create mode 100755 examples/vol-sparse.pl

-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-perl][PATCH 0/7] Implement sparse streams

Posted by Daniel P. Berrange 6 years, 11 months ago

On Tue, May 23, 2017 at 05:05:34PM +0200, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Privoznik (7):
>   Fix send_all() callback helper
>   Introduce flags to Stream::recv()
>   Introduce Stream::recvHole() and Stream::sendHole()
>   Introduce Stream::sparse_recv_all()
>   Introduce Stream::sparse_send_all()
>   Register VOL_DOWNLOAD_SPARSE_STREAM & VOL_UPLOAD_SPARSE_STREAM
>     constants
>   examples: Introduce vol-sparse.pl
> 
>  Changes                    |   9 ++
>  Virt.xs                    | 241 ++++++++++++++++++++++++++++++++++++++++++++-
>  examples/vol-sparse.pl     | 142 ++++++++++++++++++++++++++
>  lib/Sys/Virt/StorageVol.pm |  30 +++++-
>  lib/Sys/Virt/Stream.pm     |  70 ++++++++++++-
>  t/030-api-coverage.t       |   3 +
>  6 files changed, 483 insertions(+), 12 deletions(-)
>  create mode 100755 examples/vol-sparse.pl

ACK with the couple of renames suggested


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-perl][PATCH 0/7] Implement sparse streams

Posted by Michal Privoznik 6 years, 11 months ago

On 05/23/2017 06:16 PM, Daniel P. Berrange wrote:
> On Tue, May 23, 2017 at 05:05:34PM +0200, Michal Privoznik wrote:
>> *** BLURB HERE ***
>>
>> Michal Privoznik (7):
>>   Fix send_all() callback helper
>>   Introduce flags to Stream::recv()
>>   Introduce Stream::recvHole() and Stream::sendHole()
>>   Introduce Stream::sparse_recv_all()
>>   Introduce Stream::sparse_send_all()
>>   Register VOL_DOWNLOAD_SPARSE_STREAM & VOL_UPLOAD_SPARSE_STREAM
>>     constants
>>   examples: Introduce vol-sparse.pl
>>
>>  Changes                    |   9 ++
>>  Virt.xs                    | 241 ++++++++++++++++++++++++++++++++++++++++++++-
>>  examples/vol-sparse.pl     | 142 ++++++++++++++++++++++++++
>>  lib/Sys/Virt/StorageVol.pm |  30 +++++-
>>  lib/Sys/Virt/Stream.pm     |  70 ++++++++++++-
>>  t/030-api-coverage.t       |   3 +
>>  6 files changed, 483 insertions(+), 12 deletions(-)
>>  create mode 100755 examples/vol-sparse.pl
> 
> ACK with the couple of renames suggested

Thank you pushed. With a small bug fix too. In 7/7 in the example in
upload_skip_handler() I cannot return the retval of sysseek as the
return value is read as an integer and when trying to upload large file,
int wraps (at 2GiB) and the file transfer breaks. Obviously.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list