From nobody Sat Apr 27 18:50:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1492001784604463.46269942068125; Wed, 12 Apr 2017 05:56:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DBCC7F7B5; Wed, 12 Apr 2017 12:56:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 416CD77EB0; Wed, 12 Apr 2017 12:56:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DC54118523CE; Wed, 12 Apr 2017 12:56:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v3CCtxxV023606 for ; Wed, 12 Apr 2017 08:55:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id C729A7B555; Wed, 12 Apr 2017 12:55:59 +0000 (UTC) Received: from angien.brq.redhat.com (dhcp129-47.brq.redhat.com [10.34.129.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 020F917CE0; Wed, 12 Apr 2017 12:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7DBCC7F7B5 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7DBCC7F7B5 From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 12 Apr 2017 14:55:52 +0200 Message-Id: <2ef3aa8f636065ad5d668b70526717651fd19e34.1492001736.git.pkrempa@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Peter Krempa Subject: [libvirt] [PATCH 1/2] qemu: conf: Don't leak snapshot image format conf variable X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 12 Apr 2017 12:56:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" =3D=3D20406=3D=3D 4 bytes in 1 blocks are definitely lost in loss record 6 = of 1,059 =3D=3D20406=3D=3D at 0x4C2AF3F: malloc (vg_replace_malloc.c:299) =3D=3D20406=3D=3D by 0x8F17D39: strdup (in /lib64/libc-2.24.so) =3D=3D20406=3D=3D by 0x552C0E0: virStrdup (virstring.c:784) =3D=3D20406=3D=3D by 0x54D3622: virConfGetValueString (virconf.c:945) =3D=3D20406=3D=3D by 0x144E4692: virQEMUDriverConfigLoadFile (qemu_conf.= c:687) =3D=3D20406=3D=3D by 0x1452A744: qemuStateInitialize (qemu_driver.c:664) =3D=3D20406=3D=3D by 0x55DB585: virStateInitialize (libvirt.c:770) =3D=3D20406=3D=3D by 0x124570: daemonRunStateInit (libvirtd.c:881) =3D=3D20406=3D=3D by 0x5532990: virThreadHelper (virthread.c:206) =3D=3D20406=3D=3D by 0x8C82493: start_thread (in /lib64/libpthread-2.24.= so) =3D=3D20406=3D=3D by 0x8F7FA1E: clone (in /lib64/libc-2.24.so) --- src/qemu/qemu_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 3b33e37bb..132ee664a 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -407,6 +407,7 @@ static void virQEMUDriverConfigDispose(void *obj) VIR_FREE(cfg->saveImageFormat); VIR_FREE(cfg->dumpImageFormat); + VIR_FREE(cfg->snapshotImageFormat); VIR_FREE(cfg->autoDumpPath); virStringListFree(cfg->securityDriverNames); --=20 2.12.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 18:50:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1492001788931789.8603224407952; Wed, 12 Apr 2017 05:56:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 78B663B714; Wed, 12 Apr 2017 12:56:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EC9B173C5; Wed, 12 Apr 2017 12:56:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 084CF5EC66; Wed, 12 Apr 2017 12:56:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v3CCu0I7023616 for ; Wed, 12 Apr 2017 08:56:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id D348618170; Wed, 12 Apr 2017 12:56:00 +0000 (UTC) Received: from angien.brq.redhat.com (dhcp129-47.brq.redhat.com [10.34.129.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 359257B555; Wed, 12 Apr 2017 12:55:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 78B663B714 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 78B663B714 From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 12 Apr 2017 14:55:53 +0200 Message-Id: <4e950b68d155bc233eb98b77ab16f96d73aa1f41.1492001736.git.pkrempa@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Peter Krempa Subject: [libvirt] [PATCH 2/2] qemu: conf: Don't leak 'namespaces' temporary variable while parsing config X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 12 Apr 2017 12:56:28 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" =3D=3D20406=3D=3D 8 bytes in 1 blocks are definitely lost in loss record 24= of 1,059 =3D=3D20406=3D=3D at 0x4C2CF55: calloc (vg_replace_malloc.c:711) =3D=3D20406=3D=3D by 0x54BF530: virAllocN (viralloc.c:191) =3D=3D20406=3D=3D by 0x54D37C4: virConfGetValueStringList (virconf.c:100= 1) =3D=3D20406=3D=3D by 0x144E4E8E: virQEMUDriverConfigLoadFile (qemu_conf.= c:835) =3D=3D20406=3D=3D by 0x1452A744: qemuStateInitialize (qemu_driver.c:664) =3D=3D20406=3D=3D by 0x55DB585: virStateInitialize (libvirt.c:770) =3D=3D20406=3D=3D by 0x124570: daemonRunStateInit (libvirtd.c:881) =3D=3D20406=3D=3D by 0x5532990: virThreadHelper (virthread.c:206) =3D=3D20406=3D=3D by 0x8C82493: start_thread (in /lib64/libpthread-2.24.= so) =3D=3D20406=3D=3D by 0x8F7FA1E: clone (in /lib64/libc-2.24.so) --- src/qemu/qemu_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 132ee664a..1b704daa5 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -877,6 +877,7 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr = cfg, ret =3D 0; cleanup: + virStringListFree(namespaces); virStringListFree(controllers); virStringListFree(hugetlbfs); virStringListFree(nvram); --=20 2.12.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list