Fix the broken XPath and add tests.

Peter Krempa (3):
  storage: util: Split out the gluster volume extraction code into new
    function
  test: Introduce testing of virStorageUtilGlusterExtractPoolSources
  storage: Fix XPath for looking up gluster volume name

 src/storage/storage_util.c                         |  93 +++++++++++--------
 src/storage/storage_util.h                         |   4 +
 tests/Makefile.am                                  |  15 ++-
 .../virstorageutildata/gluster-parse-basic-dst.xml |   6 ++
 .../virstorageutildata/gluster-parse-basic-src.xml |  47 ++++++++++
 .../gluster-parse-multivol-dst.xml                 |  14 +++
 .../gluster-parse-multivol-src.xml                 |  32 +++++++
 tests/virstorageutiltest.c                         | 103 +++++++++++++++++++++
 8 files changed, 272 insertions(+), 42 deletions(-)
 create mode 100644 tests/virstorageutildata/gluster-parse-basic-dst.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-multivol-dst.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml
 create mode 100644 tests/virstorageutiltest.c

-- 
2.12.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Mar 29, 2017 at 15:23:37 +0200, Peter Krempa wrote:
> Fix the broken XPath and add tests.
> 
> Peter Krempa (3):
>   storage: util: Split out the gluster volume extraction code into new
>     function
>   test: Introduce testing of virStorageUtilGlusterExtractPoolSources
>   storage: Fix XPath for looking up gluster volume name

I'll post another version of this since I found other problem in the
code. I would require changing some code in this patch, so a reorder can
be nicer.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list