From nobody Wed May 1 23:56:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1490690558683588.149521740201; Tue, 28 Mar 2017 01:42:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 37D05804F2; Tue, 28 Mar 2017 08:42:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C64593429; Tue, 28 Mar 2017 08:42:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AB8D818523CA; Tue, 28 Mar 2017 08:42:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2S8eD9V003190 for ; Tue, 28 Mar 2017 04:40:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id AD59D7B123; Tue, 28 Mar 2017 08:40:13 +0000 (UTC) Received: from dnr.brq.redhat.com (dhcp129-199.brq.redhat.com [10.34.129.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3435C7A2FE for ; Tue, 28 Mar 2017 08:40:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 37D05804F2 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 37D05804F2 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Tue, 28 Mar 2017 10:40:07 +0200 Message-Id: <00534efbbb80b77521abe125c7713979b81298f3.1490690356.git.jtomko@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCHv2 1/2] Revert "storage: Better describe logical pool creation/definition parameters" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 28 Mar 2017 08:42:37 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This reverts commit ca4515d2639057020c749470f390fe1f5981e91e which also included a functional change that broke logical storage pools not named after their volume groups. --- src/conf/storage_conf.c | 8 -------- tools/virsh.pod | 7 ------- 2 files changed, 15 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 5213503..585ca71 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -760,14 +760,6 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (VIR_STRDUP(ret->source.name, ret->name) < 0) goto error; } - if (ret->type =3D=3D VIR_STORAGE_POOL_LOGICAL && - STRNEQ(ret->name, ret->source.name)) { - virReportError(VIR_ERR_XML_ERROR, - _("for a logical pool, the pool name=3D'%s'= " - "must match the pool source name=3D'%s'"), - ret->name, ret->source.name); - goto error; - } } =20 if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) && diff --git a/tools/virsh.pod b/tools/virsh.pod index 55b71a9..43124ba 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3639,13 +3639,6 @@ follow-up command to build the pool. The I<--overwri= te> and I<--no-overwrite> flags follow the same rules as B. If just I<--build> is provided, then B is called with no flags. =20 -For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>] -must match the Volume Group name for which the pool is being defined or -created. The [I<--source-name>] if provided must match the Volume Group -name. If not provided, one will be generated using the [I<--name>]. If -provided the [I<--target>] is ignored and a target source is generated -using the [I<--source-name>] (or as generated from the [I<--name>]). - =3Ditem B I =20 Define an inactive persistent storage pool or modify an existing persisten= t one --=20 2.10.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 1 23:56:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1490690430194831.6333077646583; Tue, 28 Mar 2017 01:40:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C51FC05AA57; Tue, 28 Mar 2017 08:40:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40FD517D53; Tue, 28 Mar 2017 08:40:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D2EC85EC62; Tue, 28 Mar 2017 08:40:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2S8eEwT003195 for ; Tue, 28 Mar 2017 04:40:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7CD3B7B123; Tue, 28 Mar 2017 08:40:14 +0000 (UTC) Received: from dnr.brq.redhat.com (dhcp129-199.brq.redhat.com [10.34.129.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id 057517B146 for ; Tue, 28 Mar 2017 08:40:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6C51FC05AA57 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6C51FC05AA57 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Tue, 28 Mar 2017 10:40:08 +0200 Message-Id: <7b0cdc8d411a9b8c51ebf8fd39ad6886818afc13.1490690356.git.jtomko@redhat.com> In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCHv2 2/2] storage: Better describe logical pool creation/definition parameters X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 28 Mar 2017 08:40:29 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 From: John Ferlan https://bugzilla.redhat.com/show_bug.cgi?id=3D1398087 Clean up the virsh man page description for --pool-create-as in order to better describe how the various arguments are used when creating (or defining) a logical pool. Signed-off-by: J=C3=A1n Tomko --- tools/virsh.pod | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index 43124ba..9a52d67 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3639,6 +3639,12 @@ follow-up command to build the pool. The I<--overwri= te> and I<--no-overwrite> flags follow the same rules as B. If just I<--build> is provided, then B is called with no flags. =20 +For a "logical" pool only [I<--name>] needs to be provided. The +[I<--source-name>] if provided must match the Volume Group name. +If not provided, one will be generated using the [I<--name>]. If +provided the [I<--target>] is ignored and a target source is generated +using the [I<--source-name>] (or as generated from the [I<--name>]). + =3Ditem B I =20 Define an inactive persistent storage pool or modify an existing persisten= t one --=20 2.10.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list