Reject negative storage size

[libvirt] [PATCH 0/2] Reject negative storage size

Ján Tomko posted 2 patches 7 years ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1490618487.git.jtomko@redhat.com

src/conf/storage_conf.c |  2 +-
tools/virsh-domain.c    | 22 +++++++++++-----------
tools/virsh-host.c      |  6 +++---
tools/virsh-volume.c    |  2 +-
4 files changed, 16 insertions(+), 16 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Reject negative storage size

Posted by Ján Tomko 7 years ago

https://bugzilla.redhat.com/show_bug.cgi?id=1436119

Ján Tomko (2):
  storage: reject negative capacity
  virsh: reject more negative numbers

 src/conf/storage_conf.c |  2 +-
 tools/virsh-domain.c    | 22 +++++++++++-----------
 tools/virsh-host.c      |  6 +++---
 tools/virsh-volume.c    |  2 +-
 4 files changed, 16 insertions(+), 16 deletions(-)

-- 
2.10.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Reject negative storage size

Posted by Martin Kletzander 7 years ago

On Mon, Mar 27, 2017 at 02:42:06PM +0200, Ján Tomko wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1436119
>

Who would even!...

>Ján Tomko (2):
>  storage: reject negative capacity
>  virsh: reject more negative numbers
>

Some of these are parsing data gotten from libvirt, so it's not
preventing user input, but why couldn't they be checking the values,
right?

ACK "series" =)

> src/conf/storage_conf.c |  2 +-
> tools/virsh-domain.c    | 22 +++++++++++-----------
> tools/virsh-host.c      |  6 +++---
> tools/virsh-volume.c    |  2 +-
> 4 files changed, 16 insertions(+), 16 deletions(-)
>
>--
>2.10.2
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list