Jiri Denemark (14):
  cpu_conf: Introduce virCPUDefFreeFeatures
  cpu: Introduce virCPUExpandFeatures
  cpu: Drop unused flags from cpuArchDecode
  cpu: Move feature expansion out of cpuBaseline
  cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline
  cputest: Move instantiation of JSONDecoder in cpu-convert.py
  cputest: Rename cpu-convert.py script as cpu-cpuid.py
  cputest: Add cpuidIsSet helper to cpu-cpuid.py
  cputest: Add cpuidLeaf helper to cpu-cpuid.py
  cputest: Add "diff" command to cpu-cpuid.py
  cputest: Generate data for virCPUUpdateLive
  cputest: Disable TSX on broken models
  cputest: Disable "cmt" feature unknown to QEMU
  cputest: Add tests for virCPUUpdateLive API

 src/conf/cpu_conf.c                                |  21 ++-
 src/conf/cpu_conf.h                                |   3 +
 src/cpu/cpu.c                                      |  74 +++++++--
 src/cpu/cpu.h                                      |  15 +-
 src/cpu/cpu_arm.c                                  |   5 +-
 src/cpu/cpu_ppc64.c                                |  12 +-
 src/cpu/cpu_x86.c                                  | 109 ++++++++------
 src/libvirt_private.syms                           |   2 +
 tests/cputest.c                                    | 160 +++++++++++++++++++-
 tests/cputestdata/{cpu-convert.py => cpu-cpuid.py} | 165 +++++++++++++++++----
 tests/cputestdata/cpu-parse.sh                     |   3 +-
 tests/cputestdata/x86_64-baseline-3-expanded.xml   |  48 +++---
 tests/cputestdata/x86_64-baseline-4-expanded.xml   |  68 ++++-----
 tests/cputestdata/x86_64-baseline-5-expanded.xml   |  70 ++++-----
 .../x86_64-cpuid-A10-5800K-disabled.xml            |   7 +
 .../cputestdata/x86_64-cpuid-A10-5800K-enabled.xml |   8 +
 .../x86_64-cpuid-Core-i5-2500-disabled.xml         |   5 +
 .../x86_64-cpuid-Core-i5-2500-enabled.xml          |   9 ++
 .../x86_64-cpuid-Core-i5-2540M-disabled.xml        |   5 +
 .../x86_64-cpuid-Core-i5-2540M-enabled.xml         |   9 ++
 .../x86_64-cpuid-Core-i5-4670T-disabled.xml        |   7 +
 .../x86_64-cpuid-Core-i5-4670T-enabled.xml         |   8 +
 tests/cputestdata/x86_64-cpuid-Core-i5-4670T.json  |   4 +-
 .../x86_64-cpuid-Core-i5-6600-disabled.xml         |   5 +
 .../x86_64-cpuid-Core-i5-6600-enabled.xml          |   9 ++
 .../x86_64-cpuid-Core-i7-2600-disabled.xml         |   6 +
 .../x86_64-cpuid-Core-i7-2600-enabled.xml          |   8 +
 .../x86_64-cpuid-Core-i7-3740QM-disabled.xml       |   6 +
 .../x86_64-cpuid-Core-i7-3740QM-enabled.xml        |   8 +
 .../x86_64-cpuid-Core-i7-3770-disabled.xml         |   6 +
 .../x86_64-cpuid-Core-i7-3770-enabled.xml          |   8 +
 .../x86_64-cpuid-Core-i7-4510U-disabled.xml        |   5 +
 .../x86_64-cpuid-Core-i7-4510U-enabled.xml         |   9 ++
 .../x86_64-cpuid-Core-i7-4600U-disabled.xml        |   5 +
 .../x86_64-cpuid-Core-i7-4600U-enabled.xml         |   9 ++
 .../x86_64-cpuid-Core-i7-5600U-disabled.xml        |   5 +
 .../x86_64-cpuid-Core-i7-5600U-enabled.xml         |   9 ++
 .../x86_64-cpuid-Core2-E6850-disabled.xml          |   4 +
 .../x86_64-cpuid-Core2-E6850-enabled.xml           |   7 +
 .../x86_64-cpuid-Opteron-2350-disabled.xml         |   7 +
 .../x86_64-cpuid-Opteron-2350-enabled.xml          |   7 +
 .../x86_64-cpuid-Opteron-6234-disabled.xml         |   7 +
 .../x86_64-cpuid-Opteron-6234-enabled.xml          |   9 ++
 .../x86_64-cpuid-Phenom-B95-disabled.xml           |   7 +
 .../x86_64-cpuid-Phenom-B95-enabled.xml            |   7 +
 .../x86_64-cpuid-Xeon-E3-1245-disabled.xml         |   6 +
 .../x86_64-cpuid-Xeon-E3-1245-enabled.xml          |   9 ++
 .../x86_64-cpuid-Xeon-E5-2630-disabled.xml         |   7 +
 .../x86_64-cpuid-Xeon-E5-2630-enabled.xml          |   8 +
 .../x86_64-cpuid-Xeon-E5-2650-disabled.xml         |   8 +
 .../x86_64-cpuid-Xeon-E5-2650-enabled.xml          |   7 +
 .../x86_64-cpuid-Xeon-E7-4820-disabled.xml         |   6 +
 .../x86_64-cpuid-Xeon-E7-4820-enabled.xml          |   7 +
 .../x86_64-cpuid-Xeon-W3520-disabled.xml           |   5 +
 .../x86_64-cpuid-Xeon-W3520-enabled.xml            |   7 +
 55 files changed, 834 insertions(+), 206 deletions(-)
 rename tests/cputestdata/{cpu-convert.py => cpu-cpuid.py} (83%)
 create mode 100644 tests/cputestdata/x86_64-cpuid-A10-5800K-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-A10-5800K-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2500-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2500-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2540M-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2540M-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-4670T-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-4670T-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-6600-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-6600-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-2600-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-2600-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3740QM-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3740QM-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3770-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3770-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4600U-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4600U-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core2-E6850-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Core2-E6850-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-2350-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-2350-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-6234-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-6234-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Phenom-B95-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Phenom-B95-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E3-1245-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E3-1245-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E7-4820-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E7-4820-enabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-W3520-disabled.xml
 create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-W3520-enabled.xml

-- 
2.12.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 03/17/2017 12:36 PM, Jiri Denemark wrote:
> Jiri Denemark (14):
>   cpu_conf: Introduce virCPUDefFreeFeatures
>   cpu: Introduce virCPUExpandFeatures
>   cpu: Drop unused flags from cpuArchDecode
>   cpu: Move feature expansion out of cpuBaseline
>   cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline
>   cputest: Move instantiation of JSONDecoder in cpu-convert.py
>   cputest: Rename cpu-convert.py script as cpu-cpuid.py
>   cputest: Add cpuidIsSet helper to cpu-cpuid.py
>   cputest: Add cpuidLeaf helper to cpu-cpuid.py
>   cputest: Add "diff" command to cpu-cpuid.py
>   cputest: Generate data for virCPUUpdateLive
>   cputest: Disable TSX on broken models
>   cputest: Disable "cmt" feature unknown to QEMU
>   cputest: Add tests for virCPUUpdateLive API

Does one of these perhaps fix a segv in virCPUUpdateLive? With current
tip of master, it's being called with cpu == NULL:


Thread 5 "lt-libvirtd" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f89075bf700 (LWP 21908)]
virCPUUpdateLive (arch=VIR_ARCH_X86_64, cpu=0x0,
    dataEnabled=dataEnabled@entry=0x7f88d00078e0,
dataDisabled=0x7f88d0006430)
    at cpu/cpu.c:750
750	    if (cpu->mode != VIR_CPU_MODE_CUSTOM)
(gdb) where
#0  virCPUUpdateLive (arch=VIR_ARCH_X86_64, cpu=0x0,
    dataEnabled=dataEnabled@entry=0x7f88d00078e0,
dataDisabled=0x7f88d0006430)
    at cpu/cpu.c:750
#1  0x00007f88eb3646ff in qemuProcessUpdateLiveGuestCPU (
    asyncJob=QEMU_ASYNC_JOB_START, vm=0x7f88e01e9480, driver=0x7f88e04e9450)
    at qemu/qemu_process.c:3876
#2  qemuProcessLaunch (conn=conn@entry=0x7f88d80027f0,
    driver=driver@entry=0x7f88e04e9450, vm=vm@entry=0x7f88e01e9480,
    asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_START,
incoming=incoming@entry=0x0,
    snapshot=snapshot@entry=0x0, vmop=VIR_NETDEV_VPORT_PROFILE_OP_CREATE,
    flags=17) at qemu/qemu_process.c:5731
#3  0x00007f88eb364c66 in qemuProcessStart (conn=conn@entry=0x7f88d80027f0,
    driver=driver@entry=0x7f88e04e9450, vm=vm@entry=0x7f88e01e9480,
    asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_START,
    migrateFrom=migrateFrom@entry=0x0, migrateFd=migrateFd@entry=-1,
    migratePath=0x0, snapshot=0x0, vmop=VIR_NETDEV_VPORT_PROFILE_OP_CREATE,
    flags=17) at qemu/qemu_process.c:5927
#4  0x00007f88eb3bf9be in qemuDomainObjStart (conn=0x7f88d80027f0,
    driver=driver@entry=0x7f88e04e9450, vm=0x7f88e01e9480,
    flags=flags@entry=0, asyncJob=QEMU_ASYNC_JOB_START)
    at qemu/qemu_driver.c:6945
#5  0x00007f88eb3c00b6 in qemuDomainCreateWithFlags (dom=0x7f88d00009f0,
    flags=0) at qemu/qemu_driver.c:6999

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Sun, Mar 19, 2017 at 22:09:47 -0400, Laine Stump wrote:
> On 03/17/2017 12:36 PM, Jiri Denemark wrote:
> > Jiri Denemark (14):
> >   cpu_conf: Introduce virCPUDefFreeFeatures
> >   cpu: Introduce virCPUExpandFeatures
> >   cpu: Drop unused flags from cpuArchDecode
> >   cpu: Move feature expansion out of cpuBaseline
> >   cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline
> >   cputest: Move instantiation of JSONDecoder in cpu-convert.py
> >   cputest: Rename cpu-convert.py script as cpu-cpuid.py
> >   cputest: Add cpuidIsSet helper to cpu-cpuid.py
> >   cputest: Add cpuidLeaf helper to cpu-cpuid.py
> >   cputest: Add "diff" command to cpu-cpuid.py
> >   cputest: Generate data for virCPUUpdateLive
> >   cputest: Disable TSX on broken models
> >   cputest: Disable "cmt" feature unknown to QEMU
> >   cputest: Add tests for virCPUUpdateLive API
> 
> Does one of these perhaps fix a segv in virCPUUpdateLive? With current
> tip of master, it's being called with cpu == NULL:

Oops, none of these patches fix the crash. It's a bug in the caller not
in the virCPUUpdateLive itself. A patch is coming soon...

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Mar 17, 2017 at 05:36:38PM +0100, Jiri Denemark wrote:
> Jiri Denemark (14):
>   cpu_conf: Introduce virCPUDefFreeFeatures
>   cpu: Introduce virCPUExpandFeatures
>   cpu: Drop unused flags from cpuArchDecode
>   cpu: Move feature expansion out of cpuBaseline
>   cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline
>   cputest: Move instantiation of JSONDecoder in cpu-convert.py
>   cputest: Rename cpu-convert.py script as cpu-cpuid.py
>   cputest: Add cpuidIsSet helper to cpu-cpuid.py
>   cputest: Add cpuidLeaf helper to cpu-cpuid.py
>   cputest: Add "diff" command to cpu-cpuid.py
>   cputest: Generate data for virCPUUpdateLive
>   cputest: Disable TSX on broken models
>   cputest: Disable "cmt" feature unknown to QEMU
>   cputest: Add tests for virCPUUpdateLive API

ACK series but see my comment for patch 10/14.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Mar 27, 2017 at 16:11:17 +0200, Pavel Hrdina wrote:
> On Fri, Mar 17, 2017 at 05:36:38PM +0100, Jiri Denemark wrote:
> > Jiri Denemark (14):
> >   cpu_conf: Introduce virCPUDefFreeFeatures
> >   cpu: Introduce virCPUExpandFeatures
> >   cpu: Drop unused flags from cpuArchDecode
> >   cpu: Move feature expansion out of cpuBaseline
> >   cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline
> >   cputest: Move instantiation of JSONDecoder in cpu-convert.py
> >   cputest: Rename cpu-convert.py script as cpu-cpuid.py
> >   cputest: Add cpuidIsSet helper to cpu-cpuid.py
> >   cputest: Add cpuidLeaf helper to cpu-cpuid.py
> >   cputest: Add "diff" command to cpu-cpuid.py
> >   cputest: Generate data for virCPUUpdateLive
> >   cputest: Disable TSX on broken models
> >   cputest: Disable "cmt" feature unknown to QEMU
> >   cputest: Add tests for virCPUUpdateLive API
> 
> ACK series but see my comment for patch 10/14.

OK, I modified 10/14 according to your suggestions, checked that the
script generates identical files to those from 11/14, and pushed this
series. (And broke syntax check in non VPATH.)

Thanks

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list