storage: Fix FS pool destroy not unmounting its source

[libvirt] [PATCH 0/3] storage: Fix FS pool destroy not unmounting its source

Erik Skultety posted 3 patches 7 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1486476642.git.eskultet@redhat.com

src/libvirt_private.syms         |  1 +
src/storage/storage_backend_fs.c | 25 ++++++++++++++--------
src/util/virfile.c               | 45 ++++++++++++++++++++++++++++++++++++++++
src/util/virfile.h               |  2 ++
4 files changed, 64 insertions(+), 9 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] storage: Fix FS pool destroy not unmounting its source

Posted by Erik Skultety 7 years, 2 months ago

The issue lies in how we check whether a FS is already mounted or not, we
compare the pool's source/target with source/target in the mount's binary
output both of which can actually be just symlinks to the same location yet
failing our check on the FS being mounted, thus reporting a strange error that
the pool's source is already mounted.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1417203

Erik Skultety (3):
  storage: Fix reporting an error on an already mounted filesystem
  util: Introduce virFileComparePaths
  storage: Fix checking whether source filesystem is mounted

 src/libvirt_private.syms         |  1 +
 src/storage/storage_backend_fs.c | 25 ++++++++++++++--------
 src/util/virfile.c               | 45 ++++++++++++++++++++++++++++++++++++++++
 src/util/virfile.h               |  2 ++
 4 files changed, 64 insertions(+), 9 deletions(-)

-- 
2.10.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list