test/Makefile.am: drop WARN_CFLAGS from LDFLAGS

[libvirt] [PATCH] test/Makefile.am: drop WARN_CFLAGS from LDFLAGS

Ján Tomko posted 1 patch 6 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cff237dd4c8564cd346e4f9b5291cc8854d09556.1498492879.git.jtomko@redhat.com

tests/Makefile.am | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] test/Makefile.am: drop WARN_CFLAGS from LDFLAGS

Posted by Ján Tomko 6 years, 9 months ago

Introduced by commit 0832c58, with the intention to link with
the stack protector library.

Another instance introduced by commit 4cbc15d which separated
commandhelper_LDADD from LDADDS.

Not needed because per commit 71b54636, automake should pass
all the CFLAGS to the linker.
---
 tests/Makefile.am | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 19986dc99..3d3038e62 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -76,7 +76,6 @@ GNULIB_LIBS = \
        ../gnulib/lib/libgnu.la
 
 LDADDS = \
-	$(WARN_CFLAGS) \
 	$(NO_INDIRECT_LDFLAGS) \
 	$(PROBES_O) \
 	$(GNULIB_LIBS) \
@@ -933,7 +932,6 @@ commandtest_LDADD = $(LDADDS)
 commandhelper_SOURCES = \
 	commandhelper.c
 commandhelper_LDADD = \
-	$(WARN_CFLAGS) \
 	$(NO_INDIRECT_LDFLAGS) \
 	$(PROBES_O) \
 	../src/libvirt_util.la \
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] test/Makefile.am: drop WARN_CFLAGS from LDFLAGS

Posted by Pavel Hrdina 6 years, 9 months ago

On Mon, Jun 26, 2017 at 06:01:20PM +0200, Ján Tomko wrote:
> Introduced by commit 0832c58, with the intention to link with
> the stack protector library.
> 
> Another instance introduced by commit 4cbc15d which separated
> commandhelper_LDADD from LDADDS.
> 
> Not needed because per commit 71b54636, automake should pass
> all the CFLAGS to the linker.
> ---
>  tests/Makefile.am | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list