From nobody Sun May 19 19:00:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664270237; cv=none; d=zohomail.com; s=zohoarc; b=LAn8/vuQarSopjvqNHLiyWVrElJKUAxI4mNpdBilY2+yQ/WVruXAw+LmXtQxYFuwyb+76Bat8SDseNgubQbRZk5KaPGSRumhlr0QnkiZxBj4nDZ4ee6Ie8rN1QLQSMs4hH4OYF0Ym/YYlzxQFMhQ9z5CvQm+rSs3JdOI1UC8z7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664270237; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=b6bmDJ2QGtzQeNSI0gLQbqVPS5Fd2cAv/J4aUtcUxuM=; b=giSwzTlkPu8ht7Q8XChuCZhObTGA7MH52c3n+8zd0orbe1ccytxrgjkPbKRP6/3MdqqtYd5cZ2WxNK9sIQKd3tn8npcUXv9JU4pN6rYdMxQnRkWbjaFW61ojEabxnfF9ZOavOHrdc6uQ2qmgTeFxunE2XUtcvF+Sts22YScT4Gk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1664270237041587.4659646487875; Tue, 27 Sep 2022 02:17:17 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-154-pufRQgakOvG0a2y7IcL9Gw-1; Tue, 27 Sep 2022 05:17:12 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F02A1C160C2; Tue, 27 Sep 2022 09:17:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41DB340C83AD; Tue, 27 Sep 2022 09:17:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E56331946A45; Tue, 27 Sep 2022 09:17:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1BC351946586 for ; Tue, 27 Sep 2022 09:17:06 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E30199458A; Tue, 27 Sep 2022 09:17:06 +0000 (UTC) Received: from rein.int.mamuti.net (unknown [10.40.192.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BEC4690A1C for ; Tue, 27 Sep 2022 09:17:06 +0000 (UTC) Received: by rein.int.mamuti.net (Postfix, from userid 500) id 87F6818030E; Tue, 27 Sep 2022 11:17:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664270236; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=b6bmDJ2QGtzQeNSI0gLQbqVPS5Fd2cAv/J4aUtcUxuM=; b=C1+o5/T6cOOuKo/ILuopCXvjF6own+IVWVECDthSUJoP7LOvNkNEeUGiNixVKsnaG0/u6A PWQiDAVDCiPWAT60DsLBGOLU5+UyWjURCaXAPp98rQNG/HlLNUjXIpBzlBUcMtuoLDOf6d HOndNEDqVOgwo1O7Z8AnlmXAihwH+us= X-MC-Unique: pufRQgakOvG0a2y7IcL9Gw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH] spec: Use consistent versioning for Obsoletes Date: Tue, 27 Sep 2022 11:17:00 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664270237319100001 Content-Type: text/plain; charset="utf-8" rpmbuild is complaining it's not recommended to have unversioned Obsoletes. On the other hand using dynamic version/release is a bit too much as we know in which release a particular subpackage was removed. Let's just use the corresponding version in both cases to be consistent with all other Obsoletes in our spec file. Signed-off-by: Jiri Denemark Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 654057bf57..f7d3931b6e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -574,9 +574,9 @@ Requires: util-linux Requires: /usr/bin/qemu-img %endif %if !%{with_storage_rbd} -Obsoletes: libvirt-daemon-driver-storage-rbd < %{version}-%{release} +Obsoletes: libvirt-daemon-driver-storage-rbd < 5.2.0 %endif -Obsoletes: libvirt-daemon-driver-storage-sheepdog +Obsoletes: libvirt-daemon-driver-storage-sheepdog < 8.8.0 =20 %description daemon-driver-storage-core The storage driver plugin for the libvirtd daemon, providing --=20 2.37.3