[libvirt PATCH] gitpublish: Add suppresscc option

Erik Skultety posted 1 patch 7 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/baaea7bccad73ea9e779b1b27a9fa96aef4f5f1a.1695115949.git.eskultet@redhat.com
.gitpublish | 1 +
1 file changed, 1 insertion(+)
[libvirt PATCH] gitpublish: Add suppresscc option
Posted by Erik Skultety 7 months, 1 week ago
send-email scans the commit messages to figure out the default set of
addresses to put into CC, Acked-by/Reviewed-by, etc-by being among
them. We're quite strict about CC-ing people on libvirt-list, since
most developers are subscribed to the list anyway. Respect the rule by
avoiding CCing people solely based on the fact that they've done review
of any of previous revisions.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

I noticed this issue when sending https://listman.redhat.com/archives/libvir-list/2023-September/242173.html
and publish automatically included Dan. I guess I could have overridden the CC
explicitly to just include my own address and reduce the noise, but was too
fast to hit send.

 .gitpublish | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitpublish b/.gitpublish
index d37bf4174a..457c8c676b 100644
--- a/.gitpublish
+++ b/.gitpublish
@@ -2,3 +2,4 @@
 base = master
 to = libvir-list@redhat.com
 prefix = libvirt PATCH
+suppresscc = misc-by
-- 
2.41.0
Re: [libvirt PATCH] gitpublish: Add suppresscc option
Posted by Michal Prívozník 7 months ago
On 9/19/23 11:34, Erik Skultety wrote:
> send-email scans the commit messages to figure out the default set of
> addresses to put into CC, Acked-by/Reviewed-by, etc-by being among
> them. We're quite strict about CC-ing people on libvirt-list, since
> most developers are subscribed to the list anyway. Respect the rule by
> avoiding CCing people solely based on the fact that they've done review
> of any of previous revisions.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> 
> I noticed this issue when sending https://listman.redhat.com/archives/libvir-list/2023-September/242173.html
> and publish automatically included Dan. I guess I could have overridden the CC
> explicitly to just include my own address and reduce the noise, but was too
> fast to hit send.
> 
>  .gitpublish | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal
Re: [libvirt PATCH] gitpublish: Add suppresscc option
Posted by Erik Skultety 7 months ago
On Tue, Sep 19, 2023 at 11:34:19AM +0200, Erik Skultety wrote:
> send-email scans the commit messages to figure out the default set of
> addresses to put into CC, Acked-by/Reviewed-by, etc-by being among
> them. We're quite strict about CC-ing people on libvirt-list, since
> most developers are subscribed to the list anyway. Respect the rule by
> avoiding CCing people solely based on the fact that they've done review
> of any of previous revisions.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> 
> I noticed this issue when sending https://listman.redhat.com/archives/libvir-list/2023-September/242173.html
> and publish automatically included Dan. I guess I could have overridden the CC
> explicitly to just include my own address and reduce the noise, but was too
> fast to hit send.
> 
>  .gitpublish | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitpublish b/.gitpublish
> index d37bf4174a..457c8c676b 100644
> --- a/.gitpublish
> +++ b/.gitpublish
> @@ -2,3 +2,4 @@
>  base = master
>  to = libvir-list@redhat.com
>  prefix = libvirt PATCH
> +suppresscc = misc-by
> -- 
> 2.41.0
> 

Polite ping. Not sure how many people actually use 'git publish', but this
should help not spamming people with more mails just because they've done a
single round of review for a patch/series.

Erik