From nobody Tue May 21 16:40:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619012107; cv=none; d=zohomail.com; s=zohoarc; b=Mxxqw2l7+Yda5VtPUCsnicrVOfDm73LyE/g5gMiv9UrIlawg/uvxbqnn/GJ/Xr4pi3rJUB75iyt14UwS9IOEtdaKxdHDGUMpdp1/i+OY/gvT4AHOOzT5WD8mKVeVrl3q+w9NFXvCwPw/NdKJ4QXErl50eZihQNuwfK0vkkj3tik= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619012107; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=mPAbYOwCArLnQn9FDr27O1QCndk6Ye7lJwORLhmL9sg=; b=PxpV3BisIYfZRU1eoApKVrpjCsFc86uPy2bTLnhhtzOPJ5DXfdQK5q4O0Wjy35bosHCoPvuTzyFJpTXfdcqGhX03kCbA16VKaZNDPKcc3iWI3Jg6uJPgj7btJBRVvaMMQPAsReyIulUslVd5J+wqVXiW80MvbdJkSirUxiQQ4gs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 161901210794999.2448042109612; Wed, 21 Apr 2021 06:35:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-s8R-n9riOzW86BeMiXA0Yw-1; Wed, 21 Apr 2021 09:34:09 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C15D83DEAA; Wed, 21 Apr 2021 13:34:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28F106064B; Wed, 21 Apr 2021 13:34:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DDC4044A6E; Wed, 21 Apr 2021 13:34:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13LDY0cP019871 for ; Wed, 21 Apr 2021 09:34:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6B16B5C23E; Wed, 21 Apr 2021 13:34:00 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.195.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDB3E5C1B4 for ; Wed, 21 Apr 2021 13:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619012106; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mPAbYOwCArLnQn9FDr27O1QCndk6Ye7lJwORLhmL9sg=; b=DjwuhfMHQCVkl+eo3pW6HeFLGSTzVrz5MpYhABiLxZKmGJ/BrWgklUpA1xUBqKUyw3c1sy Os6knJb9G+aQMC4FyiCIgnH5vLBVXz3lYDb7oObucE5reF1k9Zihz5PL8+Kuv30hdjxDlB lEJaKaNQZfRv+SvpU0UyxuZiVVe8wSg= X-MC-Unique: s8R-n9riOzW86BeMiXA0Yw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH] storage_backend_fs: use MKFS ony if WITH_STORAGE_FS is defined Date: Wed, 21 Apr 2021 15:33:52 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The code in storage_backend_fs is used for storage_dir and storage_fs drivers so some parts need to be guarded by checking for WITH_STORAGE_FS. Fixes: 16c69e7aaed4cabfd8e8c19cc326854d4c480437 Signed-off-by: Pavel Hrdina --- GitLab CI faild on MacOS and FreeBSD where storage_fs is disabled. src/storage/storage_backend_fs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend= _fs.c index af645ea9de..e6a348521d 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -401,6 +401,7 @@ static int virStorageBackendExecuteMKFS(const char *device, const char *format) { +#if WITH_STORAGE_FS g_autoptr(virCommand) cmd =3D NULL; g_autofree char *mkfs =3D virFindFileInPath(MKFS); =20 @@ -431,6 +432,7 @@ virStorageBackendExecuteMKFS(const char *device, if (virCommandRun(cmd, NULL) < 0) return -1; =20 +#endif /* WITH_STORAGE_FS */ return 0; } =20 --=20 2.30.2