viracpi: Fir error format string in virAcpiParseIORTNodeHeader()

[PATCH] viracpi: Fir error format string in virAcpiParseIORTNodeHeader()

Michal Privoznik posted 1 patch 1 year, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/ab6e04d7cef6d56a7fd7b617e281b245208b9f33.1680786427.git.mprivozn@redhat.com

src/util/viracpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] viracpi: Fir error format string in virAcpiParseIORTNodeHeader()

Posted by Michal Privoznik 1 year, 1 month ago

Inside of virAcpiParseIORTNodeHeader() there's an
virReportError() which reports size of a structure using sizeof()
operator. Well, it's not well documented but the returned type of
sizeof() is apparently size_t but the format string uses %lu.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Pushed under build breaker rule. Also verified this builds successfully
on a 32bit ARM.

 src/util/viracpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/viracpi.c b/src/util/viracpi.c
index 74fff0f0ac..e66df99f03 100644
--- a/src/util/viracpi.c
+++ b/src/util/viracpi.c
@@ -102,7 +102,7 @@ virAcpiParseIORTNodeHeader(int fd,
      * least size of header itself. */
     if (nodeHeader->len < sizeof(*nodeHeader)) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("IORT table node type %1$s has invalid length: got %2$u, expected at least %3$lu"),
+                       _("IORT table node type %1$s has invalid length: got %2$u, expected at least %3$zu"),
                        NULLSTR(typeStr), (unsigned int)nodeHeader->len, sizeof(*nodeHeader));
         return -1;
     }
-- 
2.39.2