From nobody Thu May 2 19:21:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520000282381967.2260688016662; Fri, 2 Mar 2018 06:18:02 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A67F04E4C5; Fri, 2 Mar 2018 14:18:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A9975D9C5; Fri, 2 Mar 2018 14:18:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 64473181A878; Fri, 2 Mar 2018 14:17:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w22EHwwY010416 for ; Fri, 2 Mar 2018 09:17:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6009D213AEFA; Fri, 2 Mar 2018 14:17:58 +0000 (UTC) Received: from dnr.brq.redhat.com (unknown [10.43.2.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05D87213AEF8 for ; Fri, 2 Mar 2018 14:17:57 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Fri, 2 Mar 2018 15:17:55 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] conf: set postParseFailed even without ALLOW_POST_PARSE_FAIL X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 02 Mar 2018 14:18:01 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 We allow the postParse callbacks to fail for some reasons (missing emulator binary) when parsing the configs from /etc/libvirt. In that case, def->postParseFailed is set to true and the post parse callbacks are re-executed on domain startup. However this bool was only set when virDomainDefPostParse was called with the ALLOW_POST_PARSE_FAIL flag set. If the callback failed again on domain startup, the bool would be reset and subsequent startups would not attempt to reexecute the callback. Signed-off-by: J=C3=A1n Tomko --- src/conf/domain_conf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index fcafc8b2f..a248d73de 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5027,6 +5027,9 @@ virDomainDefPostParseCheckFailure(virDomainDefPtr def, unsigned int parseFlags, int ret) { + if (ret !=3D 0) + def->postParseFailed =3D true; + if (ret <=3D 0) return ret; =20 @@ -5034,7 +5037,6 @@ virDomainDefPostParseCheckFailure(virDomainDefPtr def, return -1; =20 virResetLastError(); - def->postParseFailed =3D true; return 0; } =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list