[libvirt] [dbus PATCH] connect: remove unused domain variables

Ján Tomko posted 1 patch 6 years ago
Failed in applying to current master (apply log)
src/connect.c | 2 --
1 file changed, 2 deletions(-)
[libvirt] [dbus PATCH] connect: remove unused domain variables
Posted by Ján Tomko 6 years ago
Neither virDomainRestoreFlags nor virDomainSaveImageDefineXML take a
virDomain argument.

Remove the unused domain variables.

Introduced by commits 1ce556b and 2597d41 respectively.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/connect.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/connect.c b/src/connect.c
index 8faaeaf..3a563bb 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -357,7 +357,6 @@ virtDBusConnectDomainRestoreFlags(GVariant *inArgs,
                                   GError **error)
 {
     virtDBusConnect *connect = userData;
-    g_autoptr(virDomain) domain = NULL;
     const gchar *from;
     const gchar *xml;
     guint flags;
@@ -383,7 +382,6 @@ virtDBusConnectDomainSaveImageDefineXML(GVariant *inArgs,
                                         GError **error)
 {
     virtDBusConnect *connect = userData;
-    g_autoptr(virDomain) domain = NULL;
     const gchar *file;
     const gchar *xml;
     guint flags;
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH] connect: remove unused domain variables
Posted by Pavel Hrdina 6 years ago
On Wed, Apr 18, 2018 at 03:36:00PM +0200, Ján Tomko wrote:
> Neither virDomainRestoreFlags nor virDomainSaveImageDefineXML take a
> virDomain argument.
> 
> Remove the unused domain variables.
> 
> Introduced by commits 1ce556b and 2597d41 respectively.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/connect.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list