> -----Original Message-----
> From: Peter Krempa <pkrempa@redhat.com>
> Sent: Monday, June 21, 2021 1:06 AM
> To: Duan, Zhenzhong <zhenzhong.duan@intel.com>
> Cc: libvir-list@redhat.com; Yamahata, Isaku <isaku.yamahata@intel.com>; Tian, Jun J <jun.j.tian@intel.com>; Qiang, Chenyi
> <chenyi.qiang@intel.com>
> Subject: Re: [RFC PATCH 0/7] LIBVIRT: X86: TDX support
...
> > > > Using these patches we have succesfully booted and tested a guest both
> > > > with and without TDX enabled.
> > > >
> > > >
> > > > [1] https://lkml.org/lkml/2020/11/16/1106
> > > > [2] https://github.com/codomania/libvirt/commits/v9
> > >
> > > Could you please also point to the relevant qemu patches?
> > >
> > > The first commit mentions 'query-tdx-capabilities' which is not in qemu
> > > upstream yet.
> > Hi Peter,
> >
> > Sorry, seems qemu patches link is missed in [1]. List all links below for your reference.
> >
> > kvm TDX branch: https://github.com/intel/tdx/tree/kvm
> > TDX guest branch: https://github.com/intel/tdx/tree/guest
> > TDVF branch: https://github.com/tianocore/edk2-staging/tree/TDVF
> > qemu TDX branch: https://github.com/intel/qemu-tdx/tree/tdx
> 
> In my quick search I didn't find any reference to those patches on
> the qemu-devel mailing list. Please note that libvirt accepts only
> features which are supported by the upstream releases [1] of the
> hypervisor in question.
> 
> Thus if the qemu part indeed wasn't yet posted for review to qemu-devel
> you should do so if you want this series to be accepted in libvirt.
> 
> [1] Pushed upstream waiting for the next release is okay.

For qemu-devel, here is the reference.
https://lore.kernel.org/qemu-devel/cover.1613188118.git.isaku.yamahata@intel.com/
I'm not sure why lists.nongnu.org search doesn't show result with TDX keyword.

Thanks,
Isaku Yamahata

On Mon, Jun 21, 2021 at 19:28:26 +0000, Yamahata, Isaku wrote:

[...]

> > > Sorry, seems qemu patches link is missed in [1]. List all links below for your reference.
> > >
> > > kvm TDX branch: https://github.com/intel/tdx/tree/kvm
> > > TDX guest branch: https://github.com/intel/tdx/tree/guest
> > > TDVF branch: https://github.com/tianocore/edk2-staging/tree/TDVF
> > > qemu TDX branch: https://github.com/intel/qemu-tdx/tree/tdx
> > 
> > In my quick search I didn't find any reference to those patches on
> > the qemu-devel mailing list. Please note that libvirt accepts only
> > features which are supported by the upstream releases [1] of the
> > hypervisor in question.
> > 
> > Thus if the qemu part indeed wasn't yet posted for review to qemu-devel
> > you should do so if you want this series to be accepted in libvirt.
> > 
> > [1] Pushed upstream waiting for the next release is okay.
> 
> For qemu-devel, here is the reference.
> https://lore.kernel.org/qemu-devel/cover.1613188118.git.isaku.yamahata@intel.com/
> I'm not sure why lists.nongnu.org search doesn't show result with TDX keyword.

The qemu patchset you've mentioned doesn't seem to correspond entirely
to what this libvirt patchset is adding.

I was looking for the 'query-tdx-capabilities' QMP command which is used
in patch 1 of the libvirt series, but the patchset you've mentioned
doesn't add it at all.

As noted libvirt requires that the features exposed by libvirt are
accepted by upstream qemu before adding support for them, to prevent
maintenance of diverged or non-existing features.