From nobody Wed May 15 21:29:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nokia.com ARC-Seal: i=1; a=rsa-sha256; t=1657787403; cv=none; d=zohomail.com; s=zohoarc; b=JFilNMncBtykFfIIGpDbnLw5y3k98t6Fpx0a2FAVEjMgo5W3y1s3STUbGj7mif13GW8IZ9Q65bEQ22Z26+Fa1n7xENDv7Qsqn+sQmOm/dp7kGclOtIuJPSTvYoj+KuGa9btGpkYMaPNdH2chyr/cJDWxXn9FZS5izwDtBnVLIAE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657787403; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=duHJ4/Ly/MDi7W/gNmNofp4hpIj44cf2r9LOKtWgFLI=; b=BBjU5+TgcpXy+s4sVWnJ1omsCFing9R5RCDGvRoNeA3z+1qriZjdL4JrM0UhWMLoyYxsbWZle/+4b22xuVpgN3oIssIx6nLz8Kst1wxRYCv4D1h+/KWNWgJYvk3buGOnFiO+6pErR4+oVtGDEejHCL7WYT/CGV244uwJmfMaA6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1657787403132314.2340725594894; Thu, 14 Jul 2022 01:30:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-473-_ELRHi3nNcqdwHZZDrp5HA-1; Thu, 14 Jul 2022 04:30:00 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D8C44858EEE; Thu, 14 Jul 2022 08:29:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2895218ECC; Thu, 14 Jul 2022 08:29:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D0D951947071; Thu, 14 Jul 2022 08:29:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 231C1194704A for ; Mon, 11 Jul 2022 18:14:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id F3EB52026D07; Mon, 11 Jul 2022 18:14:25 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF5A92026D64 for ; Mon, 11 Jul 2022 18:14:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4BDC8032EA for ; Mon, 11 Jul 2022 18:14:25 +0000 (UTC) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2130.outbound.protection.outlook.com [40.107.95.130]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-12-G89Fsr6YMWmVirUU8GA38w-1; Mon, 11 Jul 2022 14:14:23 -0400 Received: from BN0PR08MB6951.namprd08.prod.outlook.com (2603:10b6:408:128::14) by SN6PR08MB5101.namprd08.prod.outlook.com (2603:10b6:805:71::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Mon, 11 Jul 2022 18:14:14 +0000 Received: from BN0PR08MB6951.namprd08.prod.outlook.com ([fe80::cdbd:b036:fcdd:aef9]) by BN0PR08MB6951.namprd08.prod.outlook.com ([fe80::cdbd:b036:fcdd:aef9%6]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 18:14:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657787401; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=duHJ4/Ly/MDi7W/gNmNofp4hpIj44cf2r9LOKtWgFLI=; b=jBMc4B6aZjSxaFi5A1MKuhtOZyf6vGM1t7XHPhUikkN+BGX9ci+xRil1pS28+tOhJRj0jU RrHLbgj5oO/VueY6WL/hFMcZ3Yo7FazBL072QH1hk+UAosYJuGvq8eI7YOqEtGx9Jsnp2j F9W54napN25mRL6qMfov571ofL54Tp0= X-MC-Unique: _ELRHi3nNcqdwHZZDrp5HA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: G89Fsr6YMWmVirUU8GA38w-1 From: "Pighin, Anthony (Nokia - CA/Ottawa)" To: "libvir-list@redhat.com" Subject: Persistent Failed to attach device following transient Failed to read product/vendor ID Thread-Topic: Persistent Failed to attach device following transient Failed to read product/vendor ID Thread-Index: AdiVUVp8IG8WCA35QeyujOhpOmdaeg== Date: Mon, 11 Jul 2022 18:14:14 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f5af0b42-7fbf-416c-9d28-08da63692996 x-ms-traffictypediagnostic: SN6PR08MB5101:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: n4MylIqQL8EdYMHX14Eh5+n+yUOe+bU2BWSlWOH/I9YI8doXMLga8W14rtyec0RGKRA0tN5Xib+BRsT8sNQPQCRm4vtuvxyYFySnp1Fi4WUpzYYz0hSkQrHX+FAduONv0ogIXpGMx3t/zX41jGarh7zafO4x7ck6z0+9AFOPlb87hjn8CBU6uPXQiICyX00y/QmO/18euGGhX9xXVFnxM4YJi7dwZ2pcE30V/79IlJglD3vp/5I+BT4sunj6fKPU/M5Xbhl7s6SDeokMqlXDIeit5wNsy0RQFn0GTwNvSv6nhEF0eq5+8YIuTt6SgLJThwKFODYJ9H+7l6ANRnnXY/HeU3hiaw5RZA0XeL1mVrJ82A1OXP75PJCqyodaONeFkEQr1J/KmZO4SaO8jNUtV7AM26zxTCQ3FAXyHLf/MUJssv0Eum8Y/Bz2KKfAHfrg35kr59w/Pt8Gh3V+9cBSssOKgXPRkZ3/2qjjiPSGoNvbxJC6pikHCtUPpwzh2z5zFIHLDFgvc8Dwxycp4G3wvN8I/5yr8iPG1xBaq12ly88xSvTVy9MZGmQWs8ZG8AwuQs2/jdRy6mOxh+FrzwkmiColCQQTrbccOi0pNFrLjenSC4SOCYA/ua260f5vSGsTrfeTLnoh9CYtfM4TbQRtrEtSxCdzDig+94sDLFAF/tShbQ4H+rpK0wo5K3xcCshxX2PYsqEAu23O+mZAV/kYv2FKbuS+R4vyHO/0WgCSus7iroXqDFY9VDYyGdzR3lE/TNxqukBlvfliftcN9CoHn5GpuPePLzY1Ba0SN7DeDry5ToKHy4zFrlfe4z9dsWI7trZMoD+t4M8I6hzeQc2EohhntBgDItg2mCFsjqoRcgU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR08MB6951.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(8676002)(38070700005)(478600001)(86362001)(186003)(66476007)(66946007)(966005)(66446008)(64756008)(66556008)(76116006)(5660300002)(6916009)(38100700002)(316002)(8936002)(4744005)(55016003)(41300700001)(82960400001)(83380400001)(2906002)(6506007)(7696005)(26005)(9686003)(33656002)(52536014)(71200400001)(122000001); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XZ+01Aj8U0obzg91LzJTbv63HEsfoDmPFbUmADYZwZz+kGIt9FXFSsIKngm4?= =?us-ascii?Q?Es64x0GzQ/8ZbmVT1/Oo/Cmv+pNciBlXRp3+7IOY4llBzxDSILhxKXrQVVL3?= =?us-ascii?Q?rXRICiGJXb8qpy1lklmA8aiog77rX5IGmNYFjbFatN8jaJrBCWb0JuAJTAaa?= =?us-ascii?Q?XjnGPyUJSgkJxObw1mC23qzxkE+ANJsapy0/pqfc1V/ieuBnSwOKw8s8Gu8z?= =?us-ascii?Q?s6Lg7Io/U1xqYUptvvbsbX+E92puwjl8UEVNa3B3RzRn3Uw5CoZM/g+V1Xiw?= =?us-ascii?Q?F9PemYhrj9tFzWZ1HUbn1yU8X5eA8ixfeMBPwuj7dyTz2fuP/sRrlqR8e5xC?= =?us-ascii?Q?UiVT8knhGOdohBoGq8PLxGTnjbhOmhaMrfe8zcy1bGnW4QFyXSLKT7gdoLYd?= =?us-ascii?Q?F+sQWf3nJfe1v0iXewpCLTjF2p8CZd8QAslf/U71+d2jKD3KopWhp40Pdx9x?= =?us-ascii?Q?B6MxehKAg+Awh++G/KG17S0tNS0m0Wtqkox2qKRzOsUD9Ptk8KX/2aa5Bgyp?= =?us-ascii?Q?LeyDCUWz8LZJl2ob5rTUo9Oi/5PdExY5LRLQqDHEVYvb/tpyHmxxYH0X66Ye?= =?us-ascii?Q?fHx9FJdyDSCqjlYRqZ24L41JJ8qAZesMMZtHhz4Mv/SLKS+ImNFcUZJXWxPe?= =?us-ascii?Q?7kXXk5UglIPgIcPwgVnv1Z17K6QsE8gR7KLrtxLY96MbO6YjmFkzS1kQzIsh?= =?us-ascii?Q?Ppfi60dS5qDw/KA8O0HXUXzLinESeBJfJld4SxeKsZeirHh+lJllNFDUbGPG?= =?us-ascii?Q?/F9FkKdTd+fRgrOxo6Xq9yV7E7mCibzYDSPUADhFO7mLKh09xy47na3ioqAX?= =?us-ascii?Q?kyBreV/3JUqKc3/EgZsUjQUMJFzmYpJESClvdKjHuQqChbrkHakn1+ghp9BQ?= =?us-ascii?Q?XPqbb6MSqU00SnJYL+2peqshJnQaHbeW73ILg3IbwNqlQ/tqGFKEmTg6M7z5?= =?us-ascii?Q?Qq/ka93MluCvcLqX2mXDilfJgGQKkJ0skAzr5htYuO4jld6bHnnaudkszZGV?= =?us-ascii?Q?jaCVkA7tlA7ENZpISLV0pYcUOan0hnEZDCYWDc7nj4AIGDGNKNJ4Vg9BSDVw?= =?us-ascii?Q?UAnueZW0Ff6V1WR4uAVOUMVqPm5z21VfiWmskYg70dFnLNbbmvM9O+O4aB+1?= =?us-ascii?Q?IVYOkd7J9XYI+L4hPEzW+AWZA/bbJrsvojhTZrlqdUfWuF3MPCCx/o1LdGwe?= =?us-ascii?Q?QXTvXduMqBhZhgHKB38g9oa2grp+O3MAjWWUalp7GjZSX7sNN+vBR2JlTG2t?= =?us-ascii?Q?3GKT96rrHXrk9BQtUjaBLsDIfBtrZuv0Ue1jTclybqlcjJQskAqZnphyRbc/?= =?us-ascii?Q?wqdpCd3OvnutJyeeDg/v2398JJHT4d5otZGVG1cv6EyCY7WrfdlSAcwA/MUh?= =?us-ascii?Q?IUR10eldepuPV1eL1YaokJJB02PobR0bmQE0pgXvoMGYm5smZaGeExFWCuOD?= =?us-ascii?Q?H+NrfXLVqMb3MOUWABd4XiZtP0JwGAaJD0qqTEPedzkNnvxuTYirg172cr4L?= =?us-ascii?Q?LI4hyDM12wBTG3i3niXAFkBcZOsTf9Fa3trXvj4Q8AFottaMsxFAYdfusw2J?= =?us-ascii?Q?O2hbRSzzPfuVxlk62quuQc4kAkZbwUMSCP0F0+ck?= MIME-Version: 1.0 X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR08MB6951.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5af0b42-7fbf-416c-9d28-08da63692996 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2022 18:14:14.6486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2Hg5V7b6aBH+mhWHAjppLKgmwR6KITai46FDCJlG3uZK8jMYo/1UlLSltGk/OCfDph6Ow+3keiF4pqrQ7Hfapvjry6zQ2t4LvNty9XMSACs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR08MB5101 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mailman-Approved-At: Thu, 14 Jul 2022 08:29:54 +0000 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657787405223100001 Content-Type: text/plain; charset="utf-8" I'm attempting to solve the issue reported here: https://gitlab.com/libvirt/libvirt/-/issues/345 Hoping the originator of virHostdevDeleteMissingPCIDevices() will be able t= o comment, as I am still trying to reproduce the issue with additional debu= g in place. diff --git a/src/hypervisor/virhostdev.c b/src/hypervisor/virhostdev.c index c0ce867596..d43354963e 100644 --- a/src/hypervisor/virhostdev.c +++ b/src/hypervisor/virhostdev.c @@ -1101,11 +1101,11 @@ virHostdevReAttachPCIDevices(virHostdevManager *mgr, VIR_ERROR(_("Failed to allocate PCI device list: %s"), virGetLastErrorMessage()); virResetLastError(); - return; } - - virHostdevReAttachPCIDevicesImpl(mgr, drv_name, dom_name, pcidevs, - hostdevs, nhostdevs); + else { + virHostdevReAttachPCIDevicesImpl(mgr, drv_name, dom_name, pcidevs, + hostdevs, nhostdevs); + } /* Handle the case where PCI devices from the host went missing * during the domain lifetime */