From nobody Sun May 19 12:00:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1644360265; cv=none; d=zohomail.com; s=zohoarc; b=nYo/uK3eSsOUeYbeo4apmdFfycae8+Py/qjDNxsOzEo/oUBcef7GqkZpsWLgZC76O9MWn2Ra59BSXttjwuf6Me6digBUkLy2/9etG8bKZBYWmFwBcOt8/OxFE/P6lvS3jhzN94R4YjpNGAMlHix5L1ufdg9OHj5tFxuqGRayRJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644360265; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5ZfVnugwMYXpfAOcYNIlb7xFHUc+iwuhMZ7uJLL/dCA=; b=EDJvVPbhoWAkoMwGiS8/hxIbplsstKlpqmvdfyqAc6R33BFP3aGYrCG8aVJ3f+ogt+DllQwC+Fq7X3k+RJ+R8VREcBTHHlIxYnndm9B3K85IBgKXCI0nFm1ZWp8o9p4sEhVm+xJVJ+vCin8WjHvTbM2rOuIbc29PMMgUpVvhluY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1644360265035850.7152357524412; Tue, 8 Feb 2022 14:44:25 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-upl6JibhPYGl4j84tonqkw-1; Tue, 08 Feb 2022 17:44:21 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AA311926DA0; Tue, 8 Feb 2022 22:44:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8AB81037F56; Tue, 8 Feb 2022 22:44:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6D8371832B61; Tue, 8 Feb 2022 22:44:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 218BMmKC007044 for ; Tue, 8 Feb 2022 06:22:48 -0500 Received: by smtp.corp.redhat.com (Postfix) id 393AE2AA91; Tue, 8 Feb 2022 11:22:48 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id B7E5A2AA90 for ; Tue, 8 Feb 2022 11:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644360263; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5ZfVnugwMYXpfAOcYNIlb7xFHUc+iwuhMZ7uJLL/dCA=; b=NB6X39HFJ0W2CSCmaI6vZjhDc2gezCAlh6Utr54UVNcXZ0og1cQHpzxutczqe1HNKVzgAk 2Xmrp2bjPjV5gdPlr2C0Lp2QJtrV5lTdZmproR0rynm8U8P3yA/OD8NGYjECtprmBS3v1Z kChGvGcUEougUSqNIPPS6F/KIufrX4A= X-MC-Unique: upl6JibhPYGl4j84tonqkw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML() Date: Tue, 8 Feb 2022 12:22:36 +0100 Message-Id: <9f10423e599f818070e258edb28649f4d003cfba.1644319356.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1644360267496100001 Content-Type: text/plain; charset="utf-8" In one of my previous commits, I've changed an XPath in virCPUDefParseXML() from "boolean(./counter...)" to "./counter...)". Notice the dangling closing bracket? Well, I didn't back then. Fixes: 0fe2d8dd335054fae38b46bbbac58a4662e1a1d0 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/conf/cpu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index da83e99371..819efcea8c 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -441,7 +441,7 @@ virCPUDefParseXML(xmlXPathContextPtr ctxt, return -1; } =20 - if ((counter_node =3D virXPathNode("./counter[@name=3D'tsc'])", ct= xt))) { + if ((counter_node =3D virXPathNode("./counter[@name=3D'tsc']", ctx= t))) { tsc =3D g_new0(virHostCPUTscInfo, 1); =20 if (virXMLPropULongLong(counter_node, "frequency", 10, --=20 2.34.1