https://bugzilla.redhat.com/show_bug.cgi?id=1389313
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
src/libvirt-domain.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 26da0e7f3..4670c54e5 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -8702,7 +8702,9 @@ virDomainGetJobStats(virDomainPtr domain,
* @domain: a domain object
*
* Requests that the current background job be aborted at the
- * soonest opportunity.
+ * soonest opportunity. In case the job is a migration in a post-copy mode,
+ * virDomainAbortJob will report an error (see virDomainMigrateStartPostCopy
+ * for more details).
*
* Returns 0 in case of success and -1 in case of failure.
*/
@@ -8976,7 +8978,8 @@ virDomainMigrateGetMaxSpeed(virDomainPtr domain,
* rolled back because none of the hosts has complete state. If this happens,
* libvirt will leave the domain paused on both hosts with
* VIR_DOMAIN_PAUSED_POSTCOPY_FAILED reason. It's up to the upper layer to
- * decide what to do in such case.
+ * decide what to do in such case. Because of this, libvirt will refuse to
+ * cancel post-copy migration via virDomainAbortJob.
*
* The following domain life cycle events are emitted during post-copy
* migration:
--
2.12.0
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Mar 31, 2017 at 08:44:08PM +0200, Jiri Denemark wrote: >https://bugzilla.redhat.com/show_bug.cgi?id=1389313 > >Signed-off-by: Jiri Denemark <jdenemar@redhat.com> >--- > src/libvirt-domain.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Makes perfect sense. ACK. Do comments qualify as documentation WRT freeze rules? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Mar 31, 2017 at 21:32:32 +0200, Martin Kletzander wrote: > On Fri, Mar 31, 2017 at 08:44:08PM +0200, Jiri Denemark wrote: > >https://bugzilla.redhat.com/show_bug.cgi?id=1389313 > > > >Signed-off-by: Jiri Denemark <jdenemar@redhat.com> > >--- > > src/libvirt-domain.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > Makes perfect sense. ACK. Do comments qualify as documentation WRT > freeze rules? These comments are transformed into the API documentation so yes, I think this can be applied while we are frozen. Pushed, thanks. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.