Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
Pushed as a trivial build-braker.
src/util/virnetdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 598d1c61a..486fe4cd1 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname,
ret = 0;
cleanup:
- VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1),
+ VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1,
ret < 0 ? "Fail" : "Success");
VIR_FORCE_CLOSE(s);
--
2.12.0
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Jiri Denemark wrote: > Signed-off-by: Jiri Denemark <jdenemar@redhat.com> > --- > Pushed as a trivial build-braker. > > src/util/virnetdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c > index 598d1c61a..486fe4cd1 100644 > --- a/src/util/virnetdev.c > +++ b/src/util/virnetdev.c > @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, > > ret = 0; > cleanup: > - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), > + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, > ret < 0 ? "Fail" : "Success"); > > VIR_FORCE_CLOSE(s); Thanks for fixing that, though it requires one more fix: https://www.redhat.com/archives/libvir-list/2017-March/msg01342.html (I didn't push it right away because I wasn't able to check a complete build) > -- > 2.12.0 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list Roman Bogorodskiy -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Mar 27, 2017 at 21:58:06 +0400, Roman Bogorodskiy wrote: > Jiri Denemark wrote: > > > Signed-off-by: Jiri Denemark <jdenemar@redhat.com> > > --- > > Pushed as a trivial build-braker. > > > > src/util/virnetdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c > > index 598d1c61a..486fe4cd1 100644 > > --- a/src/util/virnetdev.c > > +++ b/src/util/virnetdev.c > > @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, > > > > ret = 0; > > cleanup: > > - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), > > + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, > > ret < 0 ? "Fail" : "Success"); > > > > VIR_FORCE_CLOSE(s); > > Thanks for fixing that, though it requires one more fix: > > https://www.redhat.com/archives/libvir-list/2017-March/msg01342.html > > (I didn't push it right away because I wasn't able to check a complete > build) Oops, sorry about this. I missed that patch and just saw a build failing on FreeBSD for this trivial reason and didn't notice there were in fact two reasons. It's probably obvious that I do not have a FreeBSD environment at hand :-) Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Jiri Denemark wrote: > On Mon, Mar 27, 2017 at 21:58:06 +0400, Roman Bogorodskiy wrote: > > Jiri Denemark wrote: > > > > > Signed-off-by: Jiri Denemark <jdenemar@redhat.com> > > > --- > > > Pushed as a trivial build-braker. > > > > > > src/util/virnetdev.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c > > > index 598d1c61a..486fe4cd1 100644 > > > --- a/src/util/virnetdev.c > > > +++ b/src/util/virnetdev.c > > > @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, > > > > > > ret = 0; > > > cleanup: > > > - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), > > > + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, > > > ret < 0 ? "Fail" : "Success"); > > > > > > VIR_FORCE_CLOSE(s); > > > > Thanks for fixing that, though it requires one more fix: > > > > https://www.redhat.com/archives/libvir-list/2017-March/msg01342.html > > > > (I didn't push it right away because I wasn't able to check a complete > > build) > > Oops, sorry about this. I missed that patch and just saw a build failing > on FreeBSD for this trivial reason and didn't notice there were in fact > two reasons. It's probably obvious that I do not have a FreeBSD > environment at hand :-) Yeah, I've just pushed the second part of the fix. Roman Bogorodskiy -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.