From nobody Mon May 13 18:27:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694606171; cv=none; d=zohomail.com; s=zohoarc; b=g/lVl6PyUoTl6CvxFMhcUEUz+4MDnIW63Lr1Lg+TexUMACwAFdmmZYeero13sqyccwbSjivblIqNs7WJeOOmiBFHzoWlM1OqHkHppTQaj7WkcUNQG/AKe0z+4J/b2Tgll4NLosfzjUU85rP2SyHpWj7AsLpmTFyI4Os0z3uyWrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694606171; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=CklcU9BpmA2no4RO+q4YRDzKj4Nlj8Byt/QL71OJGTQ=; b=TcAUCqQn3XhPxi2qIPUvpzqL0yccqcq6thCmDcS+mXxlsHQNgrutlmuZ73IT3El9o11kXx3+F2ahTXqNp1L12+UTCERMQ8QyiOJVvYNOGuXx68PYVKjuBoZ6gAIAMbSd8veMji264q0i9ipWbNu6ZDgSxD797PndvIDxHKhlUGM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16946061713661.3118738651581907; Wed, 13 Sep 2023 04:56:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-246-rjTFe4wmMdaIsqbg47cdAQ-1; Wed, 13 Sep 2023 07:56:06 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 191D180523C; Wed, 13 Sep 2023 11:56:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DF7A40C200A; Wed, 13 Sep 2023 11:56:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0D10219465B5; Wed, 13 Sep 2023 11:56:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0327619465B1 for ; Wed, 13 Sep 2023 11:55:55 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4AE8840C200B; Wed, 13 Sep 2023 11:55:55 +0000 (UTC) Received: from orca.brq.redhat.com (unknown [10.43.2.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id CBC9E40C200A; Wed, 13 Sep 2023 11:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694606170; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=CklcU9BpmA2no4RO+q4YRDzKj4Nlj8Byt/QL71OJGTQ=; b=LdtoB8xfrePCmvaHfgsnOlAtykFdJUtCnb+Jxj7G58s4bU3xsIlU2yNNLlsqLpKySU/VzQ TGvjVkdcdmLKx4nb7OMK2DuR8mOOdrziN/gXYBNJbU91NxITxwZi9zHK31S9BVEVi+pTgm 0yebQ9HQrXyNUV4/yGYPdvSB4leEgaA= X-MC-Unique: rjTFe4wmMdaIsqbg47cdAQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH] ci: jobs.sh: Add back '--no-suite syntax-check --print-errorlogs' Date: Wed, 13 Sep 2023 13:55:54 +0200 Message-ID: <96fe1625c4dad1264548b037a4a6b3c47b1a4943.1694606102.git.eskultet@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694606171655100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Commit f688a53a converted .gitlab-ci.yml to the usage of ci/jobs.sh functions, but in doing that our test options '--no-suite syntax-check --print-errorlogs' got lost in the process and since commit 8e660c52 didn't introduce them in the first place, it caused a behavioral regression. This patch adds them back. Fixes: 8e660c5286d7e2d07dd61681074bf1555955552d Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 --- Technically this is a build breaker fix, but sending for review anyway to s= ee if there's an agreement on this approach. ci/jobs.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ci/jobs.sh b/ci/jobs.sh index abd695e231..eb4a4e29cf 100644 --- a/ci/jobs.sh +++ b/ci/jobs.sh @@ -39,7 +39,10 @@ run_dist() { } =20 run_test() { + TEST_ARGS=3D"${TEST_ARGS:=3D--no-suite syntax-check --print-errorlogs}" + test -f $GIT_ROOT/build/build.ninja || run_meson_setup + run_cmd meson test -C build $TEST_ARGS } =20 --=20 2.41.0