From nobody Sun May 5 22:32:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528110828126553.4038966300072; Mon, 4 Jun 2018 04:13:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8148830AB483; Mon, 4 Jun 2018 11:13:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1414C308BDAE; Mon, 4 Jun 2018 11:13:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9EFB64CA80; Mon, 4 Jun 2018 11:13:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w54BDert006205 for ; Mon, 4 Jun 2018 07:13:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id B9F08111AF24; Mon, 4 Jun 2018 11:13:40 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D960111AF1D for ; Mon, 4 Jun 2018 11:13:37 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 4 Jun 2018 13:13:37 +0200 Message-Id: <96bd3b7df069d97a8e4b64974e361813b29bbfb5.1528107611.git.phrdina@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH] gdbus: Don't report libvirt errors for GetAll method on properties X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 04 Jun 2018 11:13:46 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" According to D-Bus specification if some property is not accessible it may be omitted in the returned list of properties. However, such error needs to be reported for Get method on that property. In libvirt-dbus this can happen for Domain.SchedulerType property for QEMU session connection. Signed-off-by: Pavel Hrdina Reviewed-by: Katerina Koukiou -- --- src/gdbus.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gdbus.c b/src/gdbus.c index 2cce6ff..4e35477 100644 --- a/src/gdbus.c +++ b/src/gdbus.c @@ -163,20 +163,19 @@ virtDBusGDBusHandlePropertyGetAll(GDBusMethodInvocati= on *invocation, { GVariant *value; g_auto(GVariantBuilder) builder; - g_autoptr(GError) error =3D NULL; =20 g_variant_builder_init(&builder, G_VARIANT_TYPE("(a{sv})")); =20 g_variant_builder_open(&builder, G_VARIANT_TYPE("a{sv}")); =20 for (gint i =3D 0; data->properties[i].name; i++) { + g_autoptr(GError) error =3D NULL; + data->properties[i].getFunc(objectPath, data->userData, &value, &error); =20 - if (error) { - g_dbus_method_invocation_return_gerror(invocation, error); - return; - } + if (error) + continue; =20 g_return_if_fail(value); =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list