From nobody Sun May 19 05:22:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1674215956; cv=none; d=zohomail.com; s=zohoarc; b=TmWtjkVoGjuHABe7xA6vBadPz/ST5HuT+NF+YhfvM+fdsUko8cSwXEqorxncAmkl2h86EAN+0a1J8YOKaum9dY8Bisc1s+hQ6pZYOJ8YF1vX3yU0zUYTLwUszdX3FnAbiR73UsiLdVCk3I/O/nnyp+jFNddM4Mcu7MmvQhaZZ9E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674215956; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=1TtcVD38o+7631t5bGq/iuXkvsystLDhRUsAcSc6ln4=; b=ed+itGljbNWfg3pDZiBv2/po9TbHYU197hKCyqSI6GcqJ1MoXXQovcJPvHz7pUGxQtJC/++lWx/BadS4P+zTIjULzgiQBBQb4C3FHe3zA4J9jaSEZxHF84Mm+rlMu9SXxCeg18KZUhdZE/1a3KaVMNDwFr6VjiVKNBMSICRXQeU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1674215956235181.321013285861; Fri, 20 Jan 2023 03:59:16 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-76-7MADrGGiN-m_5uC8BTjrDQ-1; Fri, 20 Jan 2023 06:59:11 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD671802BF5; Fri, 20 Jan 2023 11:59:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 158F4492C1B; Fri, 20 Jan 2023 11:59:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B04671946A6E; Fri, 20 Jan 2023 11:59:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1DB571946A6D for ; Fri, 20 Jan 2023 11:59:06 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0CEAE1415108; Fri, 20 Jan 2023 11:59:06 +0000 (UTC) Received: from fedora.redhat.com (ovpn-193-9.brq.redhat.com [10.40.193.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E774140EBF6 for ; Fri, 20 Jan 2023 11:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674215955; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1TtcVD38o+7631t5bGq/iuXkvsystLDhRUsAcSc6ln4=; b=R+SdaWkDSs6Fiaoyt2ZINBhMZXCrTEEZdnC1yPZFh4cqMeMpeJ67WJwchW3rVm5x2tlQiF QiVFmVamQvOOYD7aIon/F+FtNiLoud139tN/QzHu2YvCZ+BXrnFYwQ2dBjt+ocZX4b7cw+ WRokDKU8z9k7qwD/7r+BJDIJ+iDeGes= X-MC-Unique: 7MADrGGiN-m_5uC8BTjrDQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] conf: clarify some external TPM error messages Date: Fri, 20 Jan 2023 12:59:00 +0100 Message-Id: <9602633870ea269e826339e0f7315defdad369cc.1674215937.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1674215958226100001 Two of the messages referred to 'backend type' when dealing with the source type and one mentioned the 'client' attribute from an earlier iteration of the patches, even though the attribute was later changed to 'connect'. https://bugzilla.redhat.com/show_bug.cgi?id=3D2063723 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_validate.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 45965fa0fa..733399e6da 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10545,7 +10545,7 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, case VIR_DOMAIN_TPM_TYPE_EXTERNAL: if (!(type =3D virXPathString("string(./backend/source/@type)", ct= xt))) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("missing external TPM backend type")); + _("missing external TPM backend source type")); goto error; } =20 @@ -10555,7 +10555,7 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, def->data.external.source->type =3D virDomainChrTypeFromString(typ= e); if (def->data.external.source->type < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unknown backend type '%s' for external TPM"), + _("unknown backend source type '%s' for externa= l TPM"), type); goto error; } diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 39d924d4ed..1c13929281 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2757,7 +2757,7 @@ virDomainTPMDevValidate(const virDomainTPMDef *tpm) } if (tpm->data.external.source->data.nix.listen) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("only 'client' mode is supported for external= TPM device")); + _("only 'connect' mode is supported for externa= l TPM device")); return -1; } if (tpm->data.external.source->data.nix.path =3D=3D NULL) { --=20 2.39.0