spec: Xen arches have changed on Fedora 36+

[PATCH] spec: Xen arches have changed on Fedora 36+

Posted by Cole Robinson 1 year, 11 months ago

Latest fedora 36+ xen builds have dropped i686 and armv7hl builds.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 libvirt.spec.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 59d2f96709..c4ea02fc8e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -21,6 +21,9 @@
 %define arches_systemtap_64bit  %{arches_64bit}
 %define arches_dmidecode        %{arches_x86}
 %define arches_xen              %{arches_x86} aarch64
+%if 0%{?fedora} >= 36
+%define arches_xen              x86_64 aarch64
+%endif
 %define arches_vbox             %{arches_x86}
 %define arches_ceph             %{arches_64bit}
 %define arches_zfs              %{arches_x86} %{power64} %{arm}
-- 
2.36.1

Re: [PATCH] spec: Xen arches have changed on Fedora 36+

Posted by Erik Skultety 1 year, 11 months ago

On Sat, Jun 11, 2022 at 04:18:37PM -0400, Cole Robinson wrote:
> Latest fedora 36+ xen builds have dropped i686 and armv7hl builds.
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>

Re: [PATCH] spec: Xen arches have changed on Fedora 36+

Posted by Cole Robinson 1 year, 11 months ago

On 6/13/22 3:03 AM, Erik Skultety wrote:
> On Sat, Jun 11, 2022 at 04:18:37PM -0400, Cole Robinson wrote:
>> Latest fedora 36+ xen builds have dropped i686 and armv7hl builds.
>>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>> ---
> Reviewed-by: Erik Skultety <eskultet@redhat.com>
> 

Pushed, but I neglected to run the test suite before submitting, and
spec indentation was wrong :/ I pushed a trivial fix

commit aabace2aa53b4e792f94a442fe03d3c596350494
Author: Cole Robinson <crobinso@redhat.com>
Date:   Mon Jun 13 09:09:35 2022 -0400

    spec: Fix indentation

- Cole

Re: [PATCH] spec: Xen arches have changed on Fedora 36+

Posted by Erik Skultety 1 year, 11 months ago

On Mon, Jun 13, 2022 at 09:16:09AM -0400, Cole Robinson wrote:
> On 6/13/22 3:03 AM, Erik Skultety wrote:
> > On Sat, Jun 11, 2022 at 04:18:37PM -0400, Cole Robinson wrote:
> >> Latest fedora 36+ xen builds have dropped i686 and armv7hl builds.
> >>
> >> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> >> ---
> > Reviewed-by: Erik Skultety <eskultet@redhat.com>
> > 
> 
> Pushed, but I neglected to run the test suite before submitting, and
> spec indentation was wrong :/ I pushed a trivial fix
> 
> commit aabace2aa53b4e792f94a442fe03d3c596350494
> Author: Cole Robinson <crobinso@redhat.com>
> Date:   Mon Jun 13 09:09:35 2022 -0400
> 
>     spec: Fix indentation
> 
> - Cole
> 

Weird, I ran the rpmbuild with your patch in the morning hoping that any syntax
problems would be revealed and it finished just fine.

Erik

Re: [PATCH] spec: Xen arches have changed on Fedora 36+

Posted by Cole Robinson 1 year, 11 months ago

On 6/13/22 9:56 AM, Erik Skultety wrote:
> On Mon, Jun 13, 2022 at 09:16:09AM -0400, Cole Robinson wrote:
>> On 6/13/22 3:03 AM, Erik Skultety wrote:
>>> On Sat, Jun 11, 2022 at 04:18:37PM -0400, Cole Robinson wrote:
>>>> Latest fedora 36+ xen builds have dropped i686 and armv7hl builds.
>>>>
>>>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>>>> ---
>>> Reviewed-by: Erik Skultety <eskultet@redhat.com>
>>>
>>
>> Pushed, but I neglected to run the test suite before submitting, and
>> spec indentation was wrong :/ I pushed a trivial fix
>>
>> commit aabace2aa53b4e792f94a442fe03d3c596350494
>> Author: Cole Robinson <crobinso@redhat.com>
>> Date:   Mon Jun 13 09:09:35 2022 -0400
>>
>>     spec: Fix indentation
>>
>> - Cole
>>
> 
> Weird, I ran the rpmbuild with your patch in the morning hoping that any syntax
> problems would be revealed and it finished just fine.
> 

Yeah rpm build is fine, I verified that before submitting. But I forgot
about the syntax check for prettyifying the spec indentation.

- Cole