Commit v7.1.0-136-g6a6d6bb520 refactored virProcessSetMaxMemLock by
moving its part into a new virProcessSetLimit, but lost "return -1" on
error;

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/util/virprocess.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/util/virprocess.c b/src/util/virprocess.c
index 5ed0b5d0db..013afd91b4 100644
--- a/src/util/virprocess.c
+++ b/src/util/virprocess.c
@@ -926,6 +926,7 @@ virProcessSetMaxMemLock(pid_t pid, unsigned long long bytes)
                              _("cannot limit locked memory "
                                "of process %lld to %llu"),
                              (long long int)pid, bytes);
+        return -1;
     }
 
     VIR_DEBUG("Locked memory for process %lld limited to %llu bytes",
-- 
2.35.1

On Fri, Jun 10, 2022 at 06:17:23PM +0200, Jiri Denemark wrote:
> Commit v7.1.0-136-g6a6d6bb520 refactored virProcessSetMaxMemLock by
> moving its part into a new virProcessSetLimit, but lost "return -1" on
> error;
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/util/virprocess.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On Fri, Jun 10, 2022 at 17:20:30 +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 10, 2022 at 06:17:23PM +0200, Jiri Denemark wrote:
> > Commit v7.1.0-136-g6a6d6bb520 refactored virProcessSetMaxMemLock by
> > moving its part into a new virProcessSetLimit, but lost "return -1" on
> > error;
> > 
> > Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> > ---
> >  src/util/virprocess.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks, I did s/;/./ in the commit message as that's what we use to
finish sentences in languages used by non-programmers :-).

Jirka