From nobody Sun May 19 16:31:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1664451514; cv=none; d=zohomail.com; s=zohoarc; b=eBTt9Mvd6XYuaWTSR/jdksFBA5O32xb4eu47Wi30DlJIsiG89qArw2/IpYN7q4Az5RFBMQfYCW+TfGdrShpe4THIW4vqG8bNbRd+ToZjiXy4nAEbZEj6CQ68t+j+3UrOFIr7bOBn3UHOzhNPuhFClfttBzQJKccwMBGUrgHM3vA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664451514; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=lTe2PpxX1cyUxwjrENgrQx0ZeehsO6KoEzv7SjsevGk=; b=noR36PQZq3P2GgFoSD0bozFCg11U88h3naanUCTP3hHnAl0vmfVHcN6fDiROsJKzFBR969992NdeUQNQMqIt14j4Rye1VtDdZDMpJGhsVIfpwKlYlAeJmWV4pfsBU+fgBGT5b9AAGAW/RRCBU862e1Ry8/7UZdReK5nGGhLIHlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1664451514306213.2422340710824; Thu, 29 Sep 2022 04:38:34 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-124-CKwGiYy3NDCEL66-y6wMAQ-1; Thu, 29 Sep 2022 07:38:29 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4173C802801; Thu, 29 Sep 2022 11:38:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2CC4D17593; Thu, 29 Sep 2022 11:38:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 080FF1946A45; Thu, 29 Sep 2022 11:38:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1862919465B8 for ; Thu, 29 Sep 2022 11:38:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0AD44492B06; Thu, 29 Sep 2022 11:38:26 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id A64DF492B04 for ; Thu, 29 Sep 2022 11:38:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664451513; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lTe2PpxX1cyUxwjrENgrQx0ZeehsO6KoEzv7SjsevGk=; b=VrdA7iwgpL8eS7YBOXb0dmVJxbuN+TN2zC/Gl0ZzTroBfxvqFt2xG0DT+cMN5tdzRNJzfF waut6VS3AK/4+dizNDHmBBhi2P5x9qHnv0qwQc5T7yoiwWp82c9Fv/HWCR1Ad9AM48qInD q7RfgtKrMpEs4CwvWfEXd/AE0TNdw7Q= X-MC-Unique: CKwGiYy3NDCEL66-y6wMAQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemuProcessReconnect: Don't build memory paths Date: Thu, 29 Sep 2022 13:38:16 +0200 Message-Id: <8482f689ef01f7ffc35509e2374fef00085c16c9.1664451496.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664451515123100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Let me take you on a short trip to history. A long time ago, libvirt would configure all QEMUs to use $hugetlbfs/libvirt/qemu for their hugepages setup. This was problematic, because it did not allow enough separation between guests. Therefore in v3.0.0-rc1~367 the path changed to a per-domain basis: $hugetlbfs/libvirt/qemu/$domainShortName And to help with migration on daemon restart a call to qemuProcessBuildDestroyMemoryPaths() was added to qemuProcessReconnect() (well, it was named qemuProcessBuildDestroyHugepagesPath() back then, see v3.10.0-rc1~174). This was desirable then, because the memory hotplug code did not call the function, it simply assumes per-domain paths to exist. But this changed in v3.5.0-rc1~92 after which the per-domain paths are created on memory hotplug too. Therefore, it's no longer necessary to create these paths in qemuProcessReconnect(). They are created exactly when needed (domain startup and memory hotplug). Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_process.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index b05ad059c3..998f4aa63c 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8785,9 +8785,6 @@ qemuProcessReconnect(void *opaque) goto cleanup; } =20 - if (qemuProcessBuildDestroyMemoryPaths(driver, obj, NULL, true) < 0) - goto error; - if ((qemuDomainAssignAddresses(obj->def, priv->qemuCaps, driver, obj, false)) < 0) { goto error; --=20 2.35.1