[libvirt PATCH] qemu: qemu_command: clean up includes

Ján Tomko posted 1 patch 2 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/7e4d3a4dac93acb9910398d0b7359f28b56919e9.1639580091.git.jtomko@redhat.com
src/qemu/qemu_command.c | 10 ----------
1 file changed, 10 deletions(-)
[libvirt PATCH] qemu: qemu_command: clean up includes
Posted by Ján Tomko 2 years, 4 months ago
Over time, the code using them got split into other files.
(Mostly qemu_interface.c and qemu_process.c)

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_command.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 6d00105b24..b9105aa10b 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -22,7 +22,6 @@
 #include <config.h>
 
 #include "qemu_command.h"
-#include "qemu_hostdev.h"
 #include "qemu_capabilities.h"
 #include "qemu_dbus.h"
 #include "qemu_interface.h"
@@ -30,14 +29,11 @@
 #include "qemu_security.h"
 #include "qemu_slirp.h"
 #include "qemu_block.h"
-#include "cpu/cpu.h"
 #include "viralloc.h"
 #include "virlog.h"
 #include "virarch.h"
 #include "virerror.h"
 #include "virfile.h"
-#include "virnetdev.h"
-#include "virnetdevbridge.h"
 #include "virqemu.h"
 #include "virstring.h"
 #include "virtime.h"
@@ -50,7 +46,6 @@
 #include "snapshot_conf.h"
 #include "storage_conf.h"
 #include "secret_conf.h"
-#include "virnetdevtap.h"
 #include "virnetdevopenvswitch.h"
 #include "device_conf.h"
 #include "storage_source_conf.h"
@@ -60,11 +55,6 @@
 #include "virgic.h"
 #include "virmdev.h"
 #include "virdomainsnapshotobjlist.h"
-#if defined(__linux__)
-# include <linux/capability.h>
-#endif
-#include "logging/log_manager.h"
-#include "logging/log_protocol.h"
 #include "virutil.h"
 #include "virsecureerase.h"
 
-- 
2.31.1

Re: [libvirt PATCH] qemu: qemu_command: clean up includes
Posted by Ani Sinha 2 years, 4 months ago
On Wed, Dec 15, 2021 at 8:47 PM Ján Tomko <jtomko@redhat.com> wrote:
>
> Over time, the code using them got split into other files.
> (Mostly qemu_interface.c and qemu_process.c)
>
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Ani Sinha <ani@anisinha.ca>

> ---
>  src/qemu/qemu_command.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 6d00105b24..b9105aa10b 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -22,7 +22,6 @@
>  #include <config.h>
>
>  #include "qemu_command.h"
> -#include "qemu_hostdev.h"
>  #include "qemu_capabilities.h"
>  #include "qemu_dbus.h"
>  #include "qemu_interface.h"
> @@ -30,14 +29,11 @@
>  #include "qemu_security.h"
>  #include "qemu_slirp.h"
>  #include "qemu_block.h"
> -#include "cpu/cpu.h"
>  #include "viralloc.h"
>  #include "virlog.h"
>  #include "virarch.h"
>  #include "virerror.h"
>  #include "virfile.h"
> -#include "virnetdev.h"
> -#include "virnetdevbridge.h"
>  #include "virqemu.h"
>  #include "virstring.h"
>  #include "virtime.h"
> @@ -50,7 +46,6 @@
>  #include "snapshot_conf.h"
>  #include "storage_conf.h"
>  #include "secret_conf.h"
> -#include "virnetdevtap.h"
>  #include "virnetdevopenvswitch.h"
>  #include "device_conf.h"
>  #include "storage_source_conf.h"
> @@ -60,11 +55,6 @@
>  #include "virgic.h"
>  #include "virmdev.h"
>  #include "virdomainsnapshotobjlist.h"
> -#if defined(__linux__)
> -# include <linux/capability.h>
> -#endif
> -#include "logging/log_manager.h"
> -#include "logging/log_protocol.h"
>  #include "virutil.h"
>  #include "virsecureerase.h"
>
> --
> 2.31.1
>