ci: integration: Set an expiration on logs artifacts

[libvirt PATCH] ci: integration: Set an expiration on logs artifacts

Posted by Erik Skultety 1 year, 3 months ago

The default expiry time is 30 days. Since the RPM artifacts coming from
the previous pipeline stages are set to expire in 1 day we can set the
failed integration job log artifacts to the same value. The sentiment
here is that if an integration job legitimately failed (i.e. not with
an infrastructure failure) unless it was fixed in the meantime it will
fail the next day with the scheduled pipeline again, meaning, that even
if the older log artifacts are removed, they'll be immediately
replaced with fresh ones.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

If you look at:
- https://gitlab.com/libvirt/libvirt/-/jobs/3563902921
- https://gitlab.com/libvirt/libvirt/-/jobs/3557946738

you can clearly see that the artifacts are still taking up (although small)
some GitLab storage space which is unnecessary since anyone interested in
debugging would opt into getting the latest ones anyway.


 ci/integration-template.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ci/integration-template.yml b/ci/integration-template.yml
index 61cd034009..9141d5cedf 100644
--- a/ci/integration-template.yml
+++ b/ci/integration-template.yml
@@ -94,6 +94,7 @@
     SCRATCH_DIR: "/tmp/scratch"
   artifacts:
     name: logs
+    expire_in: 1 day
     paths:
       - logs
     when: on_failure
-- 
2.39.0

Re: [libvirt PATCH] ci: integration: Set an expiration on logs artifacts

Posted by Daniel P. Berrangé 1 year, 3 months ago

On Thu, Jan 12, 2023 at 08:05:34AM +0100, Erik Skultety wrote:
> The default expiry time is 30 days. Since the RPM artifacts coming from
> the previous pipeline stages are set to expire in 1 day we can set the
> failed integration job log artifacts to the same value. The sentiment
> here is that if an integration job legitimately failed (i.e. not with
> an infrastructure failure) unless it was fixed in the meantime it will
> fail the next day with the scheduled pipeline again, meaning, that even
> if the older log artifacts are removed, they'll be immediately
> replaced with fresh ones.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> 
> If you look at:
> - https://gitlab.com/libvirt/libvirt/-/jobs/3563902921
> - https://gitlab.com/libvirt/libvirt/-/jobs/3557946738
> 
> you can clearly see that the artifacts are still taking up (although small)
> some GitLab storage space which is unnecessary since anyone interested in
> debugging would opt into getting the latest ones anyway.
> 
> 
>  ci/integration-template.yml | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|