conf: Avoid leaking blockers from virDomainCapsCPUModel

[libvirt] [PATCH] conf: Avoid leaking blockers from virDomainCapsCPUModel

Jiri Denemark posted 1 patch 6 years, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/6a2bfbe075330f04125a3afdfd56f795e8b31754.1509013379.git.jdenemar@redhat.com

src/conf/domain_capabilities.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] conf: Avoid leaking blockers from virDomainCapsCPUModel

Posted by Jiri Denemark 6 years, 6 months ago

When adding CPU usability blockers I forgot to properly free them when
in virDomainCapsCPUModelsDispose.

Reported-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/conf/domain_capabilities.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index 729d905e2..7f96ff386 100644
--- a/src/conf/domain_capabilities.c
+++ b/src/conf/domain_capabilities.c
@@ -94,8 +94,10 @@ virDomainCapsCPUModelsDispose(void *obj)
     virDomainCapsCPUModelsPtr cpuModels = obj;
     size_t i;
 
-    for (i = 0; i < cpuModels->nmodels; i++)
+    for (i = 0; i < cpuModels->nmodels; i++) {
         VIR_FREE(cpuModels->models[i].name);
+        virStringListFree(cpuModels->models[i].blockers);
+    }
 
     VIR_FREE(cpuModels->models);
 }
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: Avoid leaking blockers from virDomainCapsCPUModel

Posted by Pavel Hrdina 6 years, 6 months ago

On Thu, Oct 26, 2017 at 12:22:59PM +0200, Jiri Denemark wrote:
> When adding CPU usability blockers I forgot to properly free them when
> in virDomainCapsCPUModelsDispose.
> 
> Reported-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/conf/domain_capabilities.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list