[libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition

Cole Robinson posted 1 patch 5 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/5d84835e09cb4a71f97dd03289d14be5e78af86f.1525383292.git.crobinso@redhat.com
Test syntax-check passed
tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 +
tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml  | 1 +
tests/domaincapsschemadata/bhyve_uefi.x86_64.xml  | 1 +
tests/domaincapsschemadata/libxl-xenfv-usb.xml    | 1 +
tests/domaincapsschemadata/libxl-xenpv-usb.xml    | 1 +
5 files changed, 5 insertions(+)
[libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition
Posted by Cole Robinson 5 years, 11 months ago
Introduced in 8525b9694. Some files weren't updated. I'm just
guessing on the bhyve ones

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
Pushes as a build breaker

 tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 +
 tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml  | 1 +
 tests/domaincapsschemadata/bhyve_uefi.x86_64.xml  | 1 +
 tests/domaincapsschemadata/libxl-xenfv-usb.xml    | 1 +
 tests/domaincapsschemadata/libxl-xenpv-usb.xml    | 1 +
 5 files changed, 5 insertions(+)

diff --git a/tests/domaincapsschemadata/bhyve_basic.x86_64.xml b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml
index 70e36e97e9..055d05b568 100644
--- a/tests/domaincapsschemadata/bhyve_basic.x86_64.xml
+++ b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml
@@ -2,6 +2,7 @@
   <path>/usr/sbin/bhyve</path>
   <domain>bhyve</domain>
   <arch>x86_64</arch>
+  <iothreads supported='no'/>
   <os supported='yes'>
     <loader supported='no'/>
   </os>
diff --git a/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml
index 19b76da456..b22ca43ba0 100644
--- a/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml
+++ b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml
@@ -2,6 +2,7 @@
   <path>/usr/sbin/bhyve</path>
   <domain>bhyve</domain>
   <arch>x86_64</arch>
+  <iothreads supported='no'/>
   <os supported='yes'>
     <loader supported='yes'>
       <value>/foo/bar</value>
diff --git a/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml
index c278df038a..625a55e70c 100644
--- a/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml
+++ b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml
@@ -2,6 +2,7 @@
   <path>/usr/sbin/bhyve</path>
   <domain>bhyve</domain>
   <arch>x86_64</arch>
+  <iothreads supported='no'/>
   <os supported='yes'>
     <loader supported='yes'>
       <value>/foo/bar</value>
diff --git a/tests/domaincapsschemadata/libxl-xenfv-usb.xml b/tests/domaincapsschemadata/libxl-xenfv-usb.xml
index dfa992cb71..3f245e8961 100644
--- a/tests/domaincapsschemadata/libxl-xenfv-usb.xml
+++ b/tests/domaincapsschemadata/libxl-xenfv-usb.xml
@@ -4,6 +4,7 @@
   <machine>xenfv</machine>
   <arch>x86_64</arch>
   <vcpu max='128'/>
+  <iothreads supported='no'/>
   <os supported='yes'>
     <loader supported='yes'>
       <value>/usr/lib/xen/boot/hvmloader</value>
diff --git a/tests/domaincapsschemadata/libxl-xenpv-usb.xml b/tests/domaincapsschemadata/libxl-xenpv-usb.xml
index 8277a9efdd..2bcd588c0f 100644
--- a/tests/domaincapsschemadata/libxl-xenpv-usb.xml
+++ b/tests/domaincapsschemadata/libxl-xenpv-usb.xml
@@ -4,6 +4,7 @@
   <machine>xenpv</machine>
   <arch>x86_64</arch>
   <vcpu max='512'/>
+  <iothreads supported='no'/>
   <os supported='yes'>
     <loader supported='no'/>
   </os>
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition
Posted by Martin Kletzander 5 years, 11 months ago
On Thu, May 03, 2018 at 05:35:10PM -0400, Cole Robinson wrote:
>Introduced in 8525b9694. Some files weren't updated. I'm just
>guessing on the bhyve ones
>
>Signed-off-by: Cole Robinson <crobinso@redhat.com>
>---
>Pushes as a build breaker
>
> tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 +
> tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml  | 1 +
> tests/domaincapsschemadata/bhyve_uefi.x86_64.xml  | 1 +
> tests/domaincapsschemadata/libxl-xenfv-usb.xml    | 1 +
> tests/domaincapsschemadata/libxl-xenpv-usb.xml    | 1 +

Oh, thanks for fixing this.  I found two libxl-* that I needed to fix, but I
wonder how come I haven't found out about these others.  They are using the same
driver!  I'm guessing there is something host-dependent or ... I don't know.
Maybe we have travis misconfigured?

Anyway, thanks again and sorry for that.

Martin--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition
Posted by Cole Robinson 5 years, 11 months ago
On 05/03/2018 06:50 PM, Martin Kletzander wrote:
> On Thu, May 03, 2018 at 05:35:10PM -0400, Cole Robinson wrote:
>> Introduced in 8525b9694. Some files weren't updated. I'm just
>> guessing on the bhyve ones
>>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>> ---
>> Pushes as a build breaker
>>
>> tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 +
>> tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml  | 1 +
>> tests/domaincapsschemadata/bhyve_uefi.x86_64.xml  | 1 +
>> tests/domaincapsschemadata/libxl-xenfv-usb.xml    | 1 +
>> tests/domaincapsschemadata/libxl-xenpv-usb.xml    | 1 +
> 
> Oh, thanks for fixing this.  I found two libxl-* that I needed to fix,
> but I
> wonder how come I haven't found out about these others.  They are using
> the same
> driver!  I'm guessing there is something host-dependent or ... I don't
> know.
> Maybe we have travis misconfigured?
> 

Seems like there's one set of files used if libxl is new enough, another
set are used if libxl is old.

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list