virsh: migrate --timeout-postcopy requires --postcopy

[libvirt] [PATCH] virsh: migrate --timeout-postcopy requires --postcopy

Jiri Denemark posted 1 patch 6 years, 7 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/5a5b2ae8a2b973850b587692baf8f3fe677cc03e.1504887999.git.jdenemar@redhat.com

tools/virsh-domain.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[libvirt] [PATCH] virsh: migrate --timeout-postcopy requires --postcopy

Posted by Jiri Denemark 6 years, 7 months ago

Requesting an automated switch to a post-copy migration (using
--timeout-postcopy) without actually enabling post-copy migration (using
--postcopy) doesn't really do anything. Let's make this dependency
explicit to avoid unexpected behavior.

https://bugzilla.redhat.com/show_bug.cgi?id=1455023

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 tools/virsh-domain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f235c66b07..a3f3b7c7bd 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10768,6 +10768,7 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd)
     VSH_EXCLUSIVE_OPTIONS("live", "offline");
     VSH_EXCLUSIVE_OPTIONS("timeout-suspend", "timeout-postcopy");
     VSH_REQUIRE_OPTION("postcopy-after-precopy", "postcopy");
+    VSH_REQUIRE_OPTION("timeout-postcopy", "postcopy");
     VSH_REQUIRE_OPTION("persistent-xml", "persistent");
 
     if (!(dom = virshCommandOptDomain(ctl, cmd, NULL)))
-- 
2.14.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: migrate --timeout-postcopy requires --postcopy

Posted by Peter Krempa 6 years, 7 months ago

On Fri, Sep 08, 2017 at 18:26:39 +0200, Jiri Denemark wrote:
> Requesting an automated switch to a post-copy migration (using
> --timeout-postcopy) without actually enabling post-copy migration (using
> --postcopy) doesn't really do anything. Let's make this dependency
> explicit to avoid unexpected behavior.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1455023
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  tools/virsh-domain.c | 1 +
>  1 file changed, 1 insertion(+)

ACK, although this really is obious.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list