[PATCH] tests: Add missing test cases to vmx2xmltest

Martin Kletzander posted 1 patch 2 years, 8 months ago
Failed in applying to current master (apply log)
tests/vmx2xmldata/serial-pipe-client-vm.xml  | 1 +
tests/vmx2xmldata/serial-pipe-server-app.xml | 1 +
tests/vmx2xmltest.c                          | 2 ++
3 files changed, 4 insertions(+)
create mode 120000 tests/vmx2xmldata/serial-pipe-client-vm.xml
create mode 120000 tests/vmx2xmldata/serial-pipe-server-app.xml
[PATCH] tests: Add missing test cases to vmx2xmltest
Posted by Martin Kletzander 2 years, 8 months ago
Commit 42b2f35d36a9e was meant to test all four combinations of
serial-pipe-{server,client}-{app,vm} files, but did only add the files and by
mistake duplicated the tests.  Those were later removed as duplicates, so add
them back in.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
This is based on top of this series:

  https://listman.redhat.com/archives/libvir-list/2021-August/msg00533.html

For completeness sake (and CI testing) the branch is also available here:

  https://gitlab.com/nertpinx/libvirt/-/tree/vmx

 tests/vmx2xmldata/serial-pipe-client-vm.xml  | 1 +
 tests/vmx2xmldata/serial-pipe-server-app.xml | 1 +
 tests/vmx2xmltest.c                          | 2 ++
 3 files changed, 4 insertions(+)
 create mode 120000 tests/vmx2xmldata/serial-pipe-client-vm.xml
 create mode 120000 tests/vmx2xmldata/serial-pipe-server-app.xml

diff --git a/tests/vmx2xmldata/serial-pipe-client-vm.xml b/tests/vmx2xmldata/serial-pipe-client-vm.xml
new file mode 120000
index 000000000000..44e3e1ee6e77
--- /dev/null
+++ b/tests/vmx2xmldata/serial-pipe-client-vm.xml
@@ -0,0 +1 @@
+serial-pipe.xml
\ No newline at end of file
diff --git a/tests/vmx2xmldata/serial-pipe-server-app.xml b/tests/vmx2xmldata/serial-pipe-server-app.xml
new file mode 120000
index 000000000000..44e3e1ee6e77
--- /dev/null
+++ b/tests/vmx2xmldata/serial-pipe-server-app.xml
@@ -0,0 +1 @@
+serial-pipe.xml
\ No newline at end of file
diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c
index c97c4c045e95..33bf24371743 100644
--- a/tests/vmx2xmltest.c
+++ b/tests/vmx2xmltest.c
@@ -271,6 +271,8 @@ mymain(void)
     DO_TEST("serial-file");
     DO_TEST("serial-device");
     DO_TEST("serial-pipe-client-app");
+    DO_TEST("serial-pipe-client-vm");
+    DO_TEST("serial-pipe-server-app");
     DO_TEST("serial-pipe-server-vm");
     DO_TEST("serial-network-server");
     DO_TEST("serial-network-client");
-- 
2.32.0

Re: [PATCH] tests: Add missing test cases to vmx2xmltest
Posted by Ján Tomko 2 years, 8 months ago
On a Thursday in 2021, Martin Kletzander wrote:
>Commit 42b2f35d36a9e was meant to test all four combinations of
>serial-pipe-{server,client}-{app,vm} files, but did only add the files and by
>mistake duplicated the tests.  Those were later removed as duplicates, so add
>them back in.
>
>Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>---
>This is based on top of this series:
>
>  https://listman.redhat.com/archives/libvir-list/2021-August/msg00533.html
>
>For completeness sake (and CI testing) the branch is also available here:
>
>  https://gitlab.com/nertpinx/libvirt/-/tree/vmx
>
> tests/vmx2xmldata/serial-pipe-client-vm.xml  | 1 +
> tests/vmx2xmldata/serial-pipe-server-app.xml | 1 +
> tests/vmx2xmltest.c                          | 2 ++
> 3 files changed, 4 insertions(+)
> create mode 120000 tests/vmx2xmldata/serial-pipe-client-vm.xml
> create mode 120000 tests/vmx2xmldata/serial-pipe-server-app.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano