From nobody Sat May 18 15:08:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1692962677; cv=none; d=zohomail.com; s=zohoarc; b=KeVJT2fqN7Gvl6Ft4uKB7dl/itsNE5It2+KasEUnGU1iAyjVM1W+3CIfu9LYGIPorkIi7yevZ+qZhdn69xXNAuwdtPmI/TpArwrdVTNGj95OyTEju33w4KzEgshJgQQCD5B4N/2Fvof7VliVpl4r+ncsWbUUj14ZR/mIc9uwsoQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692962677; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=pstgo9c0RY2ByyRuTHbb056MHtdgYVU7rMIFGSxoqWI=; b=V6+CddzU4tdURZWexabvQPPIMvDwFoTnkO/MTIJL/ib/GNRpMySmFxTMJAcQH8tp8PkRqkfHy0hbIdvxKq5MntqfAf/3GjdHjkHQfuzRpM8vDSHpIcbT9lx609TOffFIpfyzQZc2p97yp7GGjN7vYtfuv6Mq5CgVrwMWeS2isc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1692962677455726.6295332147109; Fri, 25 Aug 2023 04:24:37 -0700 (PDT) Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-cK8-2507Mcq2-BRfhY1LhA-1; Fri, 25 Aug 2023 07:24:33 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 233862808E6A; Fri, 25 Aug 2023 11:24:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5EADB112131B; Fri, 25 Aug 2023 11:24:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 11D7219465B1; Fri, 25 Aug 2023 11:24:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BB40819465A8 for ; Fri, 25 Aug 2023 11:24:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9771F6B59A; Fri, 25 Aug 2023 11:24:26 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E863568FF for ; Fri, 25 Aug 2023 11:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692962676; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=pstgo9c0RY2ByyRuTHbb056MHtdgYVU7rMIFGSxoqWI=; b=PeO3thfrBFi/lnqR21UJ4XWw3ZJ73EmCEykuXE6d99+He0bLBnxw0oXQpV0LPeAo3agalJ NBREFavwsPuag1zTYsGT+UyiOKkVDwNzZL25Wn06sBHn8hPU+4p9pZcl807Qd0WzHQ66MF eKlBI5BxCudNn+DI8AvrVLZRd+y2CSc= X-MC-Unique: cK8-2507Mcq2-BRfhY1LhA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] virsh-network: Drop unused variables in cmdNetworkMetadata() Date: Fri, 25 Aug 2023 13:24:24 +0200 Message-ID: <5912de7189a6ba5c97be8bdbd86d66aa804877ed.1692962652.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1692962679873100001 Content-Type: text/plain; charset="utf-8"; x-default="true" In one of recent commits two variable were introduced (@ctxt and @doc) that are not used. This breaks a build with clang who's able to identify that. Signed-off-by: Michal Privoznik --- Pushed under trivial and build breaker rules. tools/virsh-network.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index f9fea0a126..5655254699 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -597,7 +597,6 @@ static bool cmdNetworkMetadata(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshNetwork) net =3D NULL; - g_autoptr(xmlXPathContext) ctxt =3D NULL; bool config =3D vshCommandOptBool(cmd, "config"); bool live =3D vshCommandOptBool(cmd, "live"); bool current =3D vshCommandOptBool(cmd, "current"); @@ -661,7 +660,7 @@ cmdNetworkMetadata(vshControl *ctl, const vshCmd *cmd) vshPrintExtra(ctl, "%s\n", _("Metadata modified")); } else { g_autofree char *data =3D NULL; - g_autoptr(xmlDoc) doc =3D NULL; + /* get */ if (!(data =3D virNetworkGetMetadata(net, VIR_NETWORK_METADATA_ELE= MENT, uri, flags))) --=20 2.41.0