From nobody Wed May 15 14:20:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621604448; cv=none; d=zohomail.com; s=zohoarc; b=QKi20rdyXq60PW8vpaXfoK4djV0zmjCaVFIdOTKVlXhmAKCfbPyTF8VSK4Eb6XjfhTcx0/zFZTp9H2pn06hVUpirdGQqQ8jMvA3fmkfARY4kIVdnx9uM1nkxQN59D9CU0cfxkNuP2L46kLOjbB90OoWsm/w0mXha9rZR8BKBUyU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621604448; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=LYUNZ/arcCPLN4dIJ/Tb3jDWCOJW6+DxhoCW+mwv3Gw=; b=bi7drB5kRn+aEUGQEWfuRJn0t7u2YS/7u8w6d+kMv/FxKDN97TShYuozFLyqRjGh4VamhHriCe0qhhSBJuMG7Ft5v0kWFCUvJXZPaoUuGie1wJMl6qnXcOguyQ+a4VmDTyGOrrDIcWEr9VskrCEwWBfXqhzsXg7eQk4eLWOw768= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621604448725626.1460225887697; Fri, 21 May 2021 06:40:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-q6m3mKd7NUash3OcTs4W-g-1; Fri, 21 May 2021 09:40:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B9958015F8; Fri, 21 May 2021 13:40:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A510D6267F; Fri, 21 May 2021 13:40:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8ED041801028; Fri, 21 May 2021 13:40:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14LDeaOA005120 for ; Fri, 21 May 2021 09:40:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id A02E91A87B; Fri, 21 May 2021 13:40:36 +0000 (UTC) Received: from antique-work.lan (unknown [10.40.195.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DC7BE158 for ; Fri, 21 May 2021 13:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621604447; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=LYUNZ/arcCPLN4dIJ/Tb3jDWCOJW6+DxhoCW+mwv3Gw=; b=UIVn9Bh3K1+p54g2wHKTgywt65Omjtm52F3TFYyA02dRiGUkPH9/LUlCJoqy7PEsjv8liK 6MxYKy+nejbgjIDQOP701YEjLtScWwgYBoO52E7jdTft/v8htDXgsudXPRSZ9uCs4PndJO mR2EGK1kn5bNE9bd3pctTxQOF7OcevY= X-MC-Unique: q6m3mKd7NUash3OcTs4W-g-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH] Revert "qemuDomainSetNumaParamsLive: set nodeset for root cgroup" Date: Fri, 21 May 2021 15:40:26 +0200 Message-Id: <58c7a405e8272032b1381db8e4e9db7f55fa14d4.1621604361.git.phrdina@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This reverts commit <1b22dd6dd44202094e0f78f887cbe790c00e9ebc>. First of all, the reverted commit is incomplete. It only sets cpuset.mems in the VM root cgroup when the API is used but there is no code that would do the same when the VM is started. Libvirt never places any process into the VM root cgroup directly. All the supporting processes like slirp-helper or dbus-daemon are placed into the emulator sub-cgroup and all the QEMU threads are distributed between emulator, vcpu* and iothread* sub-cgroups. The scenario described in the reverted commit can happen only if someone manually adds any process there which we should not care about. If we would like to set the limit in the VM root cgroup we need to introduce better logic: - set both (old and new) numa group in the VM root cgroup - change the numa group in all sub-cgroups to new value - finally set only the new value in the VM root cgroup The simplest fix now is to revert the commit. Signed-off-by: Pavel Hrdina Reviewed-by: Michal Privoznik --- src/qemu/qemu_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e10e699a1a..a972662c3f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8797,10 +8797,6 @@ qemuDomainSetNumaParamsLive(virDomainObj *vm, return -1; } =20 - /* set nodeset for root cgroup */ - if (virCgroupSetCpusetMems(priv->cgroup, nodeset_str) < 0) - return -1; - return 0; } =20 --=20 2.31.1